git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
* [PATCH v3] blame.c: replace instance of !oidcmp for oideq
@ 2020-09-09 13:15 Edmundo Carmona Antoranz
  2020-09-09 18:33 ` Derrick Stolee
  0 siblings, 1 reply; 2+ messages in thread
From: Edmundo Carmona Antoranz @ 2020-09-09 13:15 UTC (permalink / raw)
  To: dstolee, git, peff; +Cc: Edmundo Carmona Antoranz

0906ac2b (blame: use changed-path Bloom filters, 2020-04-16)
introduced a call to oidcmp() that should be replaced with oideq()
defined in 14438c4 (introduce hasheq() and oideq(), 2018-08-28)

Signed-off-by: Edmundo Carmona Antoranz <eantoranz@gmail.com>
---
 blame.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/blame.c b/blame.c
index da7e28800e..a8abe86ae4 100644
--- a/blame.c
+++ b/blame.c
@@ -1352,8 +1352,8 @@ static struct blame_origin *find_origin(struct repository *r,
 	else {
 		int compute_diff = 1;
 		if (origin->commit->parents &&
-		    !oidcmp(&parent->object.oid,
-			    &origin->commit->parents->item->object.oid))
+		    oideq(&parent->object.oid,
+			  &origin->commit->parents->item->object.oid))
 			compute_diff = maybe_changed_path(r, origin, bd);
 
 		if (compute_diff)
-- 
2.28.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v3] blame.c: replace instance of !oidcmp for oideq
  2020-09-09 13:15 [PATCH v3] blame.c: replace instance of !oidcmp for oideq Edmundo Carmona Antoranz
@ 2020-09-09 18:33 ` Derrick Stolee
  0 siblings, 0 replies; 2+ messages in thread
From: Derrick Stolee @ 2020-09-09 18:33 UTC (permalink / raw)
  To: Edmundo Carmona Antoranz, dstolee, git, peff

On 9/9/2020 9:15 AM, Edmundo Carmona Antoranz wrote:
> 0906ac2b (blame: use changed-path Bloom filters, 2020-04-16)
> introduced a call to oidcmp() that should be replaced with oideq()
> defined in 14438c4 (introduce hasheq() and oideq(), 2018-08-28)

LGTM. Thanks.

-Stolee

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-09 18:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-09 13:15 [PATCH v3] blame.c: replace instance of !oidcmp for oideq Edmundo Carmona Antoranz
2020-09-09 18:33 ` Derrick Stolee

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).