From: Philip Oakley <philipoakley@iee.email>
To: Taylor Blau <me@ttaylorr.com>
Cc: GitList <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>,
"René Scharfe" <l.s.r@web.de>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 2/4] repack.c: LLP64 compatibility, upcast unity for left shift
Date: Tue, 30 Nov 2021 22:28:05 +0000 [thread overview]
Message-ID: <13a5828d-596f-a215-7053-9570be939e5b@iee.email> (raw)
In-Reply-To: <YaVxwFuMeK3QsfZj@nand.local>
On 30/11/2021 00:35, Taylor Blau wrote:
> On Fri, Nov 26, 2021 at 11:36:12AM +0000, Philip Oakley wrote:
>> Visual Studio reports C4334 "was 64-bit shift intended" warning
>> because of size miss-match.
> s/miss-/mis
Thanks. Looks like "miss-pelling" is my blind spot. Will fix V2 soon.
>
>> diff --git a/builtin/repack.c b/builtin/repack.c
>> index 0b2d1e5d82..6da66474fd 100644
>> --- a/builtin/repack.c
>> +++ b/builtin/repack.c
>> @@ -842,7 +842,7 @@ int cmd_repack(int argc, const char **argv, const char *prefix)
>> fname_old = mkpathdup("%s-%s%s",
>> packtmp, item->string, exts[ext].name);
>>
>> - if (((uintptr_t)item->util) & (1 << ext)) {
>> + if (((uintptr_t)item->util) & ((uintptr_t)1 << ext)) {
> This line blames to me from back in 2fcb03b52d (builtin/repack.c: don't
> move existing packs out of the way, 2020-11-17).
>
> The proposed fix here looks good to me (though we were never at any
> practical risk of getting bitten by a down-cast here since the maximum
> value for `ext` is 5).
Agreed. It's nice to get a head start on fixing a group of warnings.
> Thanks,
> Taylor
Philip
next prev parent reply other threads:[~2021-11-30 22:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 11:36 [PATCH 0/4] Fix LLP64 `(size_t)1` compatibility VS C4334 warnings Philip Oakley
2021-11-26 11:36 ` [PATCH 1/4] mergesort.c: LLP64 compatibility, upcast unity for left shift Philip Oakley
2021-11-27 7:32 ` René Scharfe
2021-11-29 23:49 ` Philip Oakley
2021-11-26 11:36 ` [PATCH 2/4] repack.c: " Philip Oakley
2021-11-30 0:35 ` Taylor Blau
2021-11-30 22:28 ` Philip Oakley [this message]
2021-11-26 11:36 ` [PATCH 3/4] diffcore-delta.c: " Philip Oakley
2021-11-29 14:44 ` Derrick Stolee
2021-11-29 23:50 ` Philip Oakley
2021-11-26 11:36 ` [PATCH 4/4] object-file.c: " Philip Oakley
2021-11-29 14:44 ` [PATCH 0/4] Fix LLP64 `(size_t)1` compatibility VS C4334 warnings Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13a5828d-596f-a215-7053-9570be939e5b@iee.email \
--to=philipoakley@iee.email \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).