From: Felipe Contreras <felipe.contreras@gmail.com>
To: git@vger.kernel.org
Cc: Duy Nguyen <pclouds@gmail.com>,
Felipe Contreras <felipe.contreras@gmail.com>
Subject: [PATCH v10 07/15] contrib: related: add helper Person classes
Date: Sat, 12 Oct 2013 02:06:11 -0500 [thread overview]
Message-ID: <1381561584-20529-3-git-send-email-felipe.contreras@gmail.com> (raw)
In-Reply-To: <1381561584-20529-1-git-send-email-felipe.contreras@gmail.com>
No functional changes.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
contrib/related/git-related | 71 +++++++++++++++++++++++++++++++++++----------
1 file changed, 56 insertions(+), 15 deletions(-)
diff --git a/contrib/related/git-related b/contrib/related/git-related
index ffce839..3cac925 100755
--- a/contrib/related/git-related
+++ b/contrib/related/git-related
@@ -8,13 +8,59 @@ $min_percent = 10
$files = []
$rev_args = []
-class Commit
+class Person
+
+ attr_reader :roles
+
+ def initialize(name, email)
+ @name = name
+ @email = email
+ @commits = {}
+ end
+
+ def add_role(commit)
+ @commits[commit] = true
+ end
+
+ def <=>(b)
+ self.size <=> b.size
+ end
+
+ def size
+ @commits.size
+ end
+
+ def to_s
+ '%s <%s>' % [@name, @email]
+ end
+
+end
- attr_reader :persons
+class Persons
+
+ @@index = {}
+
+ include Enumerable
+
+ def each(&block)
+ @@index.values.each(&block)
+ end
+
+ def self.get(name, email)
+ id = [name, email]
+ person = @@index[id]
+ if not person
+ person = @@index[id] = Person.new(name, email)
+ end
+ person
+ end
+
+end
+
+class Commit
def initialize(id)
@id = id
- @persons = []
end
def parse(data)
@@ -23,17 +69,18 @@ class Commit
if not in_body
case line
when /^author ([^<>]+) <(\S+)> (.+)$/
- @persons << '%s <%s>' % [$1, $2]
+ author = Persons.get($1, $2)
+ author.add_role(@id)
when /^$/
in_body = true
end
else
if line =~ /^(Signed-off-by|Reviewed-by|Acked-by|Cc): ([^<>]+) <(\S+?)>$/
- @persons << '%s <%s>' % [$2, $3]
+ person = Persons.get($2, $3)
+ person.add_role(@id)
end
end
end
- @persons.uniq!
end
end
@@ -152,16 +199,10 @@ else
end
commits.import
-count_per_person = Hash.new(0)
-
-commits.each do |id, commit|
- commit.persons.each do |person|
- count_per_person[person] += 1
- end
-end
+persons = Persons.new
-count_per_person.each do |person, count|
- percent = count.to_f * 100 / commits.size
+persons.sort.reverse.each do |person|
+ percent = person.size.to_f * 100 / commits.size
next if percent < $min_percent
puts '%s (involved: %u%%)' % [person, percent]
end
--
1.8.4-fc
next prev parent reply other threads:[~2013-10-12 7:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-12 7:06 [PATCH v10 14/15] contrib: related: add option to show commits Felipe Contreras
2013-10-12 7:06 ` [PATCH v10 00/15] New git-related helper Felipe Contreras
2013-10-12 7:06 ` Felipe Contreras [this message]
2013-10-12 7:06 ` [PATCH v10 10/15] contrib: related: group persons with same email Felipe Contreras
2013-10-12 7:06 ` [PATCH v10 02/15] contrib: related: add tests Felipe Contreras
2013-10-12 7:06 ` [PATCH v10 06/15] contrib: related: print the amount of involvement Felipe Contreras
2013-10-12 7:06 ` [PATCH v10 04/15] contrib: related: add option to parse from committish Felipe Contreras
2013-10-12 7:06 ` [PATCH v10 15/15] contrib: related: add README Felipe Contreras
2013-10-12 7:06 ` [PATCH v10 09/15] contrib: related: add support for more roles Felipe Contreras
2013-10-12 7:06 ` [PATCH v10 03/15] contrib: related: add support for multiple patches Felipe Contreras
2013-10-12 7:06 ` [PATCH v10 12/15] contrib: related: add mailmap support Felipe Contreras
2013-10-12 7:06 ` [PATCH v10 13/15] contrib: related: add option parsing Felipe Contreras
2013-10-12 7:06 ` [PATCH v10 01/15] Add new git-related helper to contrib Felipe Contreras
2013-10-12 7:06 ` [PATCH v10 11/15] contrib: related: allow usage on other directories Felipe Contreras
2013-10-12 7:06 ` [PATCH v10 08/15] contrib: related: show role count Felipe Contreras
2013-10-12 7:06 ` [PATCH v10 05/15] contrib: related: parse committish like format-patch Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381561584-20529-3-git-send-email-felipe.contreras@gmail.com \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).