git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: git@vger.kernel.org
Cc: Duy Nguyen <pclouds@gmail.com>,
	Felipe Contreras <felipe.contreras@gmail.com>
Subject: [PATCH v10 05/15] contrib: related: parse committish like format-patch
Date: Sat, 12 Oct 2013 02:06:24 -0500	[thread overview]
Message-ID: <1381561584-20529-16-git-send-email-felipe.contreras@gmail.com> (raw)
In-Reply-To: <1381561584-20529-1-git-send-email-felipe.contreras@gmail.com>

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/related/git-related    | 15 +++++++++++++++
 contrib/related/test-related.t | 10 ++++++++++
 2 files changed, 25 insertions(+)

diff --git a/contrib/related/git-related b/contrib/related/git-related
index 4f78304..80e1f17 100755
--- a/contrib/related/git-related
+++ b/contrib/related/git-related
@@ -108,6 +108,21 @@ class Commits
   end
 
   def from_rev_args(args)
+    revs = []
+
+    File.popen(%w[git rev-parse --revs-only --default HEAD --symbolic] + args).each do |rev|
+      revs << rev.chomp
+    end
+
+    case revs.size
+    when 1
+      r = revs[0]
+      r = '^' + r if r[0] != '-'
+      args = [ r, 'HEAD' ]
+    else
+      args = revs
+    end
+
     File.popen(%w[git rev-list --reverse] + args) do |p|
       p.each do |e|
         id = e.chomp
diff --git a/contrib/related/test-related.t b/contrib/related/test-related.t
index b623d69..39b4fe9 100755
--- a/contrib/related/test-related.t
+++ b/contrib/related/test-related.t
@@ -74,4 +74,14 @@ test_expect_success "from committish" "
 	test_cmp expected actual
 "
 
+test_expect_success "from single rev committish" "
+	git related -1 master | sort > actual &&
+	cat > expected <<-EOF &&
+	John Doe <john@doe.com>
+	John Poppins <john@doe.com>
+	Jon Stewart <jon@stewart.com>
+	EOF
+	test_cmp expected actual
+"
+
 test_done
-- 
1.8.4-fc

      parent reply	other threads:[~2013-10-12  7:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-12  7:06 [PATCH v10 14/15] contrib: related: add option to show commits Felipe Contreras
2013-10-12  7:06 ` [PATCH v10 00/15] New git-related helper Felipe Contreras
2013-10-12  7:06 ` [PATCH v10 07/15] contrib: related: add helper Person classes Felipe Contreras
2013-10-12  7:06 ` [PATCH v10 10/15] contrib: related: group persons with same email Felipe Contreras
2013-10-12  7:06 ` [PATCH v10 02/15] contrib: related: add tests Felipe Contreras
2013-10-12  7:06 ` [PATCH v10 06/15] contrib: related: print the amount of involvement Felipe Contreras
2013-10-12  7:06 ` [PATCH v10 04/15] contrib: related: add option to parse from committish Felipe Contreras
2013-10-12  7:06 ` [PATCH v10 15/15] contrib: related: add README Felipe Contreras
2013-10-12  7:06 ` [PATCH v10 09/15] contrib: related: add support for more roles Felipe Contreras
2013-10-12  7:06 ` [PATCH v10 03/15] contrib: related: add support for multiple patches Felipe Contreras
2013-10-12  7:06 ` [PATCH v10 12/15] contrib: related: add mailmap support Felipe Contreras
2013-10-12  7:06 ` [PATCH v10 13/15] contrib: related: add option parsing Felipe Contreras
2013-10-12  7:06 ` [PATCH v10 01/15] Add new git-related helper to contrib Felipe Contreras
2013-10-12  7:06 ` [PATCH v10 11/15] contrib: related: allow usage on other directories Felipe Contreras
2013-10-12  7:06 ` [PATCH v10 08/15] contrib: related: show role count Felipe Contreras
2013-10-12  7:06 ` Felipe Contreras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381561584-20529-16-git-send-email-felipe.contreras@gmail.com \
    --to=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).