* [PATCH] git-remote-mediawiki: un-brace file handles in binmode calls
@ 2013-07-03 9:14 Matthieu Moy
2013-07-03 19:10 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Matthieu Moy @ 2013-07-03 9:14 UTC (permalink / raw)
To: git, gitster; +Cc: celestin.matte, Matthieu Moy
Commit e83d36b66fc turned "print STDOUT" into "print {*STDOUT}", as
suggested by perlcritic. Unfortunately, it also changed two "binmode
STDOUT" calls the same way, which does not work and yield a "Not a GLOB
reference" error.
Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
contrib/mw-to-git/git-remote-mediawiki.perl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-to-git/git-remote-mediawiki.perl
index e40c034..f8d7d2c 100755
--- a/contrib/mw-to-git/git-remote-mediawiki.perl
+++ b/contrib/mw-to-git/git-remote-mediawiki.perl
@@ -576,9 +576,9 @@ sub literal_data_raw {
my ($content) = @_;
# Avoid confusion between size in bytes and in characters
utf8::downgrade($content);
- binmode {*STDOUT}, ':raw';
+ binmode STDOUT, ':raw';
print {*STDOUT} 'data ', bytes::length($content), "\n", $content;
- binmode {*STDOUT}, ':encoding(UTF-8)';
+ binmode STDOUT, ':encoding(UTF-8)';
return;
}
--
1.8.3.1.495.g13f33cf.dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] git-remote-mediawiki: un-brace file handles in binmode calls
2013-07-03 9:14 [PATCH] git-remote-mediawiki: un-brace file handles in binmode calls Matthieu Moy
@ 2013-07-03 19:10 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2013-07-03 19:10 UTC (permalink / raw)
To: Matthieu Moy; +Cc: git, celestin.matte
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-03 19:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-03 9:14 [PATCH] git-remote-mediawiki: un-brace file handles in binmode calls Matthieu Moy
2013-07-03 19:10 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).