From: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
To: Jonathan Niedier <jrnieder@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Jens Lehmann" <Jens.Lehmann@web.de>,
"Heiko Voigt" <hvoigt@hvoigt.net>,
"Manlio Perillo" <manlio.perillo@gmail.com>,
"W. Trevor King" <wking@drexel.edu>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: [PATCH] clone: forbid --bare --separate-git-dir <dir>
Date: Sun, 6 Jan 2013 16:47:50 +0700 [thread overview]
Message-ID: <1357465670-32766-1-git-send-email-pclouds@gmail.com> (raw)
In-Reply-To: <20130106091642.GA10956@elie.Belkin>
--separate-git-dir was added to clone with the repository away from
standard position <worktree>/.git. It does not make sense to use it
without creating working directory.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
On Sun, Jan 6, 2013 at 4:16 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Duy Nguyen wrote:
>
>> And
>> because junk_work_tree is not set up for --bare, I guess we still need
>> to fix "--bare --separate-git-dir" case, or forbid it because i'm not
>> sure if that case makes sense at all.
>
> Forbidding it makes sense to me. If some day we want a git command to
> create a .git file, I don't think it should be spelled as "git clone
> --bare --separate-git-dir <repo>".
That command does not work because --separate-git-dir requires an
argument in addition to <repo>, which is taken as the target repo.
Still it's hard to find a use case for
git clone --bare --separate-git-dir <real-repo> <symlink-repo>
> In the meantime,
>
> printf '%s\n' 'gitdir: /path/to/repo' >repo.git
>
> works fine.
Yeah. A separate clone operation following by that printf should be
clearer.
builtin/clone.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/builtin/clone.c b/builtin/clone.c
index ec2f75b..360e430 100644
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -704,6 +704,12 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
if (option_origin)
die(_("--bare and --origin %s options are incompatible."),
option_origin);
+ if (real_git_dir)
+ /*
+ * If you lift this restriction, remember to
+ * clean .git in this case in remove_junk_on_signal
+ */
+ die(_("--bare and --separate-git-dir are incompatible."));
option_no_checkout = 1;
}
--
1.8.0.rc2.23.g1fb49df
next prev parent reply other threads:[~2013-01-06 9:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 20:53 [BUG] git submodule update is not fail safe Manlio Perillo
2013-01-04 21:51 ` Junio C Hamano
2013-01-05 13:52 ` Manlio Perillo
2013-01-05 14:07 ` Jens Lehmann
2013-01-05 14:01 ` Jens Lehmann
2013-01-05 14:49 ` Manlio Perillo
2013-01-05 14:50 ` Jens Lehmann
2013-01-05 20:17 ` [PATCH] clone: support atomic operation with --separate-git-dir Jens Lehmann
2013-01-05 21:20 ` Manlio Perillo
2013-01-06 6:43 ` Junio C Hamano
2013-01-06 8:49 ` Duy Nguyen
2013-01-06 9:16 ` Jonathan Nieder
2013-01-06 9:47 ` Nguyễn Thái Ngọc Duy [this message]
2013-01-06 10:19 ` [PATCH] clone: forbid --bare --separate-git-dir <dir> Jonathan Nieder
2013-01-06 23:13 ` Junio C Hamano
2013-01-07 1:18 ` Duy Nguyen
2013-01-07 2:04 ` Junio C Hamano
2013-01-08 14:16 ` Duy Nguyen
2013-01-08 17:15 ` Jens Lehmann
2013-01-08 17:45 ` Junio C Hamano
2013-01-08 23:34 ` Duy Nguyen
2013-01-08 23:42 ` Junio C Hamano
2013-01-11 3:09 ` [PATCH v2] " Nguyễn Thái Ngọc Duy
2013-01-11 3:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357465670-32766-1-git-send-email-pclouds@gmail.com \
--to=pclouds@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hvoigt@hvoigt.net \
--cc=jrnieder@gmail.com \
--cc=manlio.perillo@gmail.com \
--cc=wking@drexel.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).