* [PATCH 0/2] *** SUBJECT HERE ***
2008-08-29 8:16 [PATCH 0/6] 'git svn info' fixes Eric Wong
@ 2008-08-29 13:42 ` Thomas Rast
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Rast @ 2008-08-29 13:42 UTC (permalink / raw)
To: git; +Cc: Eric Wong, Junio C Hamano
Eric Wong wrote.
> > So should we just change all "unknown foo" tests to verify that 'git
> > svn info' errors out too?
>
> Yes, I see no reason to differ from plain svn here.
This starts getting more complicated at every turn. The included
mini-series (probably textually depends on the other 6 patches though)
"fixes" this.
HOWEVER: Subversion itself broke compatibility here. In 1.4:
$ svn info new; echo $?
new: (Not a versioned resource)
0
Note the extra linebreak and successful exit. Current git-svn
precisely matches this output. In 1.5, it's different:
$ svn info new; echo $?
svn: 'new' is not under version control
1
While it is of course up to you what you would like to do (and modulo
test_must_fail, 2/2 can still be used to fix the tests if you decide
to reject 1/2), I suggest changing to 1.5 behaviour. exit(1) is the
sane thing to do in this case, and that is already breaking
bit-for-bit compatibility with SVN 1.4, so we might as well adopt the
new error message. Of course this prevents us from comparing the
output literally in the tests, so I settled for a slightly weaker
check: failure status and mention of the filename.
Unfortunately this does raise the question whether the URL-encoding
issue treated in the other series is in fact a similar incompatibility
between 1.4 and 1.5, not a (minor but long-standing) bug in git-svn.
- Thomas
git-svn.perl | 4 +-
t/t9119-git-svn-info.sh | 73 ++++++++++++++++-------------------------------
2 files changed, 27 insertions(+), 50 deletions(-)
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 0/2] *** SUBJECT HERE ***
@ 2009-06-08 4:31 Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2009-06-08 4:31 UTC (permalink / raw)
To: git
*** BLURB HERE ***
Junio C Hamano (1):
Makefile: test-parse-options depends on parse-options.h
Kjetil Barvik (1):
symlinks.c: small style cleanup
Makefile | 2 ++
symlinks.c | 6 ++----
2 files changed, 4 insertions(+), 4 deletions(-)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-08 4:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-08 4:31 [PATCH 0/2] *** SUBJECT HERE *** Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2008-08-29 8:16 [PATCH 0/6] 'git svn info' fixes Eric Wong
2008-08-29 13:42 ` [PATCH 0/2] *** SUBJECT HERE *** Thomas Rast
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).