From: "McMullan, Jason" <jason.mcmullan@timesys.com>
To: "Junio C Hamano" <junkio@cox.net>
Cc: "Linus Torvalds" <torvalds@osdl.org>,
"GIT Mailling list" <git@vger.kernel.org>
Subject: Re: [PATCH] Handle deltified object correctly in git-*-pull family.
Date: Thu, 02 Jun 2005 13:03:49 -0400
Date: Thu, 2 Jun 2005 12:57:02 -0400 [thread overview]
Message-ID: <1117731830.32257.52.camel@jmcmullan.timesys> (raw)
In-Reply-To: <7v4qcg906f.fsf_-_@assigned-by-dhcp.cox.net>
[-- Attachment #1: Type: text/plain, Size: 1276 bytes --]
On Thu, 2005-06-02 at 09:46 -0700, Junio C Hamano wrote:
> When a remote repository is deltified, we need to get the
> objects that a deltified object we want to obtain is based upon.
> The initial parts of each retrieved SHA1 file is inflated and
> inspected to see if it is deltified, and its base object is
> asked from the remote side when it is. Since this partial
> inflation and inspection has a small performance hit, it can
> optionally be skipped by giving -d flag to git-*-pull commands.
> This flag should be used only when the remote repository is
> known to have no deltified objects.
Eww. Don't you want to attempt to get the referenced sha1 *before*
you stick the delta blob into the repository?
Otherwise, if a transfer fails, there's no good way to recover your
database through the git-*pull interfaces, ie:
Try to pull session 1:
pull tree a
pull delta b (references blob c)
pull blob c -> fails!
Try to pull session 2:
pull tree a
delta b - Found in database!
...
Or do I not understand your code properly?
(I'm working on a similar piece of code for my git-daemon protocol,
which is why I'm worried about this issue)
--
Jason McMullan <jason.mcmullan@timesys.com>
TimeSys Corporation
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-06-02 17:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7vy89ums2l.fsf@assigned-by-dhcp.cox.net>
2005-06-01 18:38 ` [PATCH] diff: mode bits fixes Junio C Hamano
2005-06-02 16:46 ` [PATCH] Handle deltified object correctly in git-*-pull family Junio C Hamano
2005-06-02 17:03 ` Linus Torvalds
2005-06-02 18:55 ` Junio C Hamano
2005-06-02 21:31 ` Nicolas Pitre
2005-06-02 21:36 ` Nicolas Pitre
2005-06-02 22:19 ` [PATCH 1/2] " Junio C Hamano
2005-06-02 22:48 ` Linus Torvalds
2005-06-02 22:20 ` [PATCH 2/2] Find size of SHA1 object without inflating everything Junio C Hamano
2005-06-02 18:57 ` [PATCH] " Junio C Hamano
2005-06-02 22:10 ` Linus Torvalds
2005-06-02 22:47 ` Junio C Hamano
2005-06-02 17:03 ` McMullan, Jason [this message]
2005-06-02 18:02 ` [PATCH] Handle deltified object correctly in git-*-pull family Junio C Hamano
2005-06-02 16:47 ` [PATCH] Use correct U*MAX Junio C Hamano
2005-06-03 23:02 ` Petr Baudis
2005-06-03 23:40 ` Junio C Hamano
2005-06-04 0:00 ` Petr Baudis
2005-06-04 0:09 ` Junio C Hamano
2005-06-02 16:49 ` [PATCH] Find size of SHA1 object without inflating everything Junio C Hamano
2005-05-30 20:00 I want to release a "git-1.0" Linus Torvalds
2005-05-30 20:49 ` Nicolas Pitre
2005-06-01 6:52 ` Junio C Hamano
2005-06-01 8:24 ` [PATCH] Add -d flag to git-pull-* family Junio C Hamano
2005-06-01 14:39 ` Nicolas Pitre
2005-06-01 16:00 ` Junio C Hamano
[not found] ` <7v1x7lk8fl.fsf_-_@assigned-by-dhcp.cox.net>
2005-06-02 0:47 ` [PATCH] Handle deltified object correctly in git-*-pull family Nicolas Pitre
2005-06-02 0:58 ` Linus Torvalds
2005-06-02 1:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1117731830.32257.52.camel@jmcmullan.timesys \
--to=jason.mcmullan@timesys.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).