* [PATCH] revision.c: fix sparse warnings (sparse algorithm)
@ 2019-01-13 20:55 Ramsay Jones
2019-01-15 14:42 ` Derrick Stolee
0 siblings, 1 reply; 3+ messages in thread
From: Ramsay Jones @ 2019-01-13 20:55 UTC (permalink / raw)
To: Derrick Stolee; +Cc: Junio C Hamano, GIT Mailing-list
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Derrick,
If you need to re-roll your 'ds/push-sparse-tree-walk' branch, could
you please squash this into the relevant patch [commit 9949aaeef4
("revision: implement sparse algorithm", 2018-12-14)].
This commit caused both 'sparse' and my 'static-check.pl' script to
complain about the visibility of the 'map_flags' variable (it is a
file local variable), so one solution would be to mark it 'static'.
However, it is simply not being used, so ...
Thanks!
ATB,
Ramsay Jones
revision.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/revision.c b/revision.c
index a048da3cf5..c4982a70b1 100644
--- a/revision.c
+++ b/revision.c
@@ -114,10 +114,9 @@ static int path_and_oids_cmp(const void *hashmap_cmp_fn_data,
return strcmp(e1->path, e2->path);
}
-int map_flags = 0;
static void paths_and_oids_init(struct hashmap *map)
{
- hashmap_init(map, (hashmap_cmp_fn) path_and_oids_cmp, &map_flags, 0);
+ hashmap_init(map, (hashmap_cmp_fn) path_and_oids_cmp, NULL, 0);
}
static void paths_and_oids_clear(struct hashmap *map)
--
2.20.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] revision.c: fix sparse warnings (sparse algorithm)
2019-01-13 20:55 [PATCH] revision.c: fix sparse warnings (sparse algorithm) Ramsay Jones
@ 2019-01-15 14:42 ` Derrick Stolee
2019-01-15 18:29 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Derrick Stolee @ 2019-01-15 14:42 UTC (permalink / raw)
To: Ramsay Jones, Derrick Stolee; +Cc: Junio C Hamano, GIT Mailing-list
On 1/13/2019 3:55 PM, Ramsay Jones wrote:
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Derrick,
>
> If you need to re-roll your 'ds/push-sparse-tree-walk' branch, could
> you please squash this into the relevant patch [commit 9949aaeef4
> ("revision: implement sparse algorithm", 2018-12-14)].
>
> This commit caused both 'sparse' and my 'static-check.pl' script to
> complain about the visibility of the 'map_flags' variable (it is a
> file local variable), so one solution would be to mark it 'static'.
> However, it is simply not being used, so ...
>
> Thanks!
>
> ATB,
> Ramsay Jones
Thanks, Ramsay! I'm rerolling the series today, so I will make this change.
-Stolee
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] revision.c: fix sparse warnings (sparse algorithm)
2019-01-15 14:42 ` Derrick Stolee
@ 2019-01-15 18:29 ` Junio C Hamano
0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2019-01-15 18:29 UTC (permalink / raw)
To: Derrick Stolee; +Cc: Ramsay Jones, Derrick Stolee, GIT Mailing-list
Derrick Stolee <stolee@gmail.com> writes:
> On 1/13/2019 3:55 PM, Ramsay Jones wrote:
>> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
>> ---
>>
>> Hi Derrick,
>>
>> If you need to re-roll your 'ds/push-sparse-tree-walk' branch, could
>> you please squash this into the relevant patch [commit 9949aaeef4
>> ("revision: implement sparse algorithm", 2018-12-14)].
>>
>> This commit caused both 'sparse' and my 'static-check.pl' script to
>> complain about the visibility of the 'map_flags' variable (it is a
>> file local variable), so one solution would be to mark it 'static'.
>> However, it is simply not being used, so ...
>>
>> Thanks!
>>
>> ATB,
>> Ramsay Jones
>
> Thanks, Ramsay! I'm rerolling the series today, so I will make this change.
>
> -Stolee
Thanks, both.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-15 18:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-13 20:55 [PATCH] revision.c: fix sparse warnings (sparse algorithm) Ramsay Jones
2019-01-15 14:42 ` Derrick Stolee
2019-01-15 18:29 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).