* [BUG] Installing git-gui (2.27.0)
@ 2020-06-08 14:02 Randall S. Becker
2020-06-23 12:47 ` Pratyush Yadav
0 siblings, 1 reply; 3+ messages in thread
From: Randall S. Becker @ 2020-06-08 14:02 UTC (permalink / raw)
To: git
Hi,
This is what I found when trying to install the whole git package on the
NonStop TNS/E platform:
DEST /usr/local/share/git-gui/lib
INSTALL 644 tclIndex
install: cannot stat 'lib/tclIndex': No such file or directory
Makefile:293: recipe for target 'install' failed
Im not sure why we are only hitting this now at 2.27.0. We dont use
git-gui anyway on this platform as it has no GUI interface. It looks like
the install script runs auto_mkindex that actually does nothing in our case,
so lib/tclIndex is not built.
This does block the install from completing successfully. To bypass, I added
the following:
index f10caedaa7..943febaf75 100644
--- a/git-gui/Makefile
+++ b/git-gui/Makefile
@@ -256,6 +256,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS
$(foreach p,$(PRELOAD_FILES),source $p\;) \
auto_mkindex lib $(patsubst lib/%,%,$(sort $(ALL_LIBFILES))) \
| $(TCL_PATH) $(QUIET_2DEVNULL); then : ok; \
+ echo >>$@ ; \
else \
echo >&2 " * $(TCL_PATH) failed; using unoptimized loading"; \
rm -f $@ ; \
Regards,
Randall
-- Brief whoami:
NonStop developer since approximately 211288444200000000
UNIX developer since approximately 421664400
-- In my real life, I talk too much.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [BUG] Installing git-gui (2.27.0)
2020-06-08 14:02 [BUG] Installing git-gui (2.27.0) Randall S. Becker
@ 2020-06-23 12:47 ` Pratyush Yadav
2020-06-23 13:21 ` Randall S. Becker
0 siblings, 1 reply; 3+ messages in thread
From: Pratyush Yadav @ 2020-06-23 12:47 UTC (permalink / raw)
To: Randall S. Becker; +Cc: git
Hi Randall,
On 08/06/20 10:02AM, Randall S. Becker wrote:
> Hi,
>
> This is what I found when trying to install the whole git package on the
> NonStop TNS/E platform:
>
> DEST /usr/local/share/git-gui/lib
> INSTALL 644 tclIndex
> install: cannot stat 'lib/tclIndex': No such file or directory
> Makefile:293: recipe for target 'install' failed
>
> Im not sure why we are only hitting this now at 2.27.0. We dont use
> git-gui anyway on this platform as it has no GUI interface. It looks like
> the install script runs auto_mkindex that actually does nothing in our case,
> so lib/tclIndex is not built.
>
> This does block the install from completing successfully. To bypass, I added
> the following:
>
> index f10caedaa7..943febaf75 100644
> --- a/git-gui/Makefile
> +++ b/git-gui/Makefile
> @@ -256,6 +256,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS
> $(foreach p,$(PRELOAD_FILES),source $p\;) \
> auto_mkindex lib $(patsubst lib/%,%,$(sort $(ALL_LIBFILES))) \
> | $(TCL_PATH) $(QUIET_2DEVNULL); then : ok; \
> + echo >>$@ ; \
> else \
> echo >&2 " * $(TCL_PATH) failed; using unoptimized loading"; \
> rm -f $@ ; \
>
IIUC, this is a NonStop-specific problem. This fix shouldn't go in the
git-gui 'master', right?
--
Regards,
Pratyush Yadav
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [BUG] Installing git-gui (2.27.0)
2020-06-23 12:47 ` Pratyush Yadav
@ 2020-06-23 13:21 ` Randall S. Becker
0 siblings, 0 replies; 3+ messages in thread
From: Randall S. Becker @ 2020-06-23 13:21 UTC (permalink / raw)
To: 'Pratyush Yadav'; +Cc: git
On, June 23, 2020 8:47 AM, Pratyush Yadav:
> On 08/06/20 10:02AM, Randall S. Becker wrote:
> > Hi,
> >
> > This is what I found when trying to install the whole git package on
> > the NonStop TNS/E platform:
> >
> > DEST /usr/local/share/git-gui/lib
> > INSTALL 644 tclIndex
> > install: cannot stat 'lib/tclIndex': No such file or directory
> > Makefile:293: recipe for target 'install' failed
> >
> > Im not sure why we are only hitting this now at 2.27.0. We dont use
> > git-gui anyway on this platform as it has no GUI interface. It looks
> > like the install script runs auto_mkindex that actually does nothing
> > in our case, so lib/tclIndex is not built.
> >
> > This does block the install from completing successfully. To bypass, I
> > added the following:
> >
> > index f10caedaa7..943febaf75 100644
> > --- a/git-gui/Makefile
> > +++ b/git-gui/Makefile
> > @@ -256,6 +256,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS
> > $(foreach p,$(PRELOAD_FILES),source $p\;) \
> > auto_mkindex lib $(patsubst lib/%,%,$(sort $(ALL_LIBFILES))) \
> > | $(TCL_PATH) $(QUIET_2DEVNULL); then : ok; \
> > + echo >>$@ ; \
> > else \
> > echo >&2 " * $(TCL_PATH) failed; using unoptimized loading";
\
> > rm -f $@ ; \
> >
>
> IIUC, this is a NonStop-specific problem. This fix shouldn't go in the
git-gui
> 'master', right?
The component is still part of the git build, so unless it can be severed by
configuration, it should go into 'master'. The Makefile should still
generate a tclIndex, which the foreach is not guaranteed to do, apparently.
Randall
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-23 13:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-08 14:02 [BUG] Installing git-gui (2.27.0) Randall S. Becker
2020-06-23 12:47 ` Pratyush Yadav
2020-06-23 13:21 ` Randall S. Becker
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).