From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: "'Duy Nguyen'" <pclouds@gmail.com>
Cc: "'Git Mailing List'" <git@vger.kernel.org>
Subject: RE: [Breakage] 2.20.0-rc0 t1404: test_i18ngrep reports 1 instead of 0 on NonStop in one case
Date: Mon, 11 Feb 2019 09:09:32 -0500 [thread overview]
Message-ID: <000601d4c213$6c7ee650$457cb2f0$@nexbridge.com> (raw)
In-Reply-To: <CACsJy8Bn+2zY6y_QqCjbB3qWM-F=3d0H5vgWj4az=md2FZ8RhA@mail.gmail.com>
On February 11, 2019 4:57, Duy Nguyen <pclouds@gmail.com> wrote:
> On Mon, Feb 11, 2019 at 2:09 AM Randall S. Becker
> <rsbecker@nexbridge.com> wrote:
> >
> > Hi All,
> >
> > I tracked down a breakage in t1404 subtest 52. The line
> >
> > test_i18ngrep "Unable to create $Q.*packed-refs.lock$Q: File exists"
> > err
>
> The message does not match, does it? Here we grep for "File exists"
> but the message you showed says "File already exists"
So if I understand this correctly, it means that NonStop is reporting a different textual error that other platforms, but is still sane. Would a fix as follows be appropriate?
@@ -614,7 +614,12 @@ test_expect_success 'delete fails cleanly if packed-refs file is locked' '
test_when_finished "rm -f .git/packed-refs.lock" &&
test_must_fail git update-ref -d $prefix/foo >out 2>err &&
git for-each-ref $prefix >actual &&
- test_i18ngrep "Unable to create $Q.*packed-refs.lock$Q: File exists" err &&
+ # Handle a difference in error reporting text on NonStop
+ if [ `uname` != "NONSTOP_KERNEL" ]; then \
+ test_i18ngrep "Unable to create $Q.*packed-refs.lock$Q: File exists" err ; \
+ else \
+ test_i18ngrep "Unable to create $Q.*packed-refs.lock$Q: File already exists" err ; \
+ fi &&
test_cmp unchanged actual
I'm not at all confident that the committers will like a hack like this but it does work.
Regards,
Randall
next prev parent reply other threads:[~2019-02-11 14:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-10 19:08 [Breakage] 2.20.0-rc0 t1404: test_i18ngrep reports 1 instead of 0 on NonStop in one case Randall S. Becker
2019-02-11 9:56 ` Duy Nguyen
2019-02-11 14:09 ` Randall S. Becker [this message]
2019-02-11 21:07 ` Junio C Hamano
2019-02-11 21:48 ` Randall S. Becker
2019-02-12 0:27 ` Jeff King
2019-02-12 0:32 ` Junio C Hamano
2019-02-12 0:35 ` Jeff King
2019-02-14 20:16 ` Re* " Junio C Hamano
2019-02-14 20:32 ` Randall S. Becker
2019-02-14 21:15 ` Junio C Hamano
2019-02-15 6:08 ` Martin Ågren
2019-02-15 17:51 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000601d4c213$6c7ee650$457cb2f0$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).