From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Duy Nguyen <pclouds@gmail.com>,
"Randall S. Becker" <rsbecker@nexbridge.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [Breakage] 2.20.0-rc0 t1404: test_i18ngrep reports 1 instead of 0 on NonStop in one case
Date: Mon, 11 Feb 2019 19:35:40 -0500 [thread overview]
Message-ID: <20190212003540.GG13301@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqpnrxg823.fsf@gitster-ct.c.googlers.com>
On Mon, Feb 11, 2019 at 04:32:52PM -0800, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > Hmm. We care to _some_ degree, since that's the condition we set up for
> > making sure that update-ref cannot take the lock. But it would probably
> > be fine to just confirm that we failed to take the lock. And there,
> > checking for just "Unable to create $Q.*packed-refs.lock" would be
> > sufficient.
>
> Yeah, that was what I was getting at. On top, we could also see
> "test -e" after noticing the failure but that probably does not help
> us prove anything.
Yeah, I don't think there is any point in "test -e". We were the ones
who created the file in the first place, so it would be very surprising
if it weren't there. ;)
-Peff
next prev parent reply other threads:[~2019-02-12 0:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-10 19:08 [Breakage] 2.20.0-rc0 t1404: test_i18ngrep reports 1 instead of 0 on NonStop in one case Randall S. Becker
2019-02-11 9:56 ` Duy Nguyen
2019-02-11 14:09 ` Randall S. Becker
2019-02-11 21:07 ` Junio C Hamano
2019-02-11 21:48 ` Randall S. Becker
2019-02-12 0:27 ` Jeff King
2019-02-12 0:32 ` Junio C Hamano
2019-02-12 0:35 ` Jeff King [this message]
2019-02-14 20:16 ` Re* " Junio C Hamano
2019-02-14 20:32 ` Randall S. Becker
2019-02-14 21:15 ` Junio C Hamano
2019-02-15 6:08 ` Martin Ågren
2019-02-15 17:51 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212003540.GG13301@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).