From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Florian Weimer <fweimer@redhat.com>,
Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>,
bug-gnulib@gnu.org
Subject: Re: [PATCH 1/2] posix: User scratch_buffer on fnmatch
Date: Thu, 14 Jan 2021 08:44:30 -0300 [thread overview]
Message-ID: <e52b7836-5e6a-5f76-317c-1041ee392a2b@linaro.org> (raw)
In-Reply-To: <ad02c0ee-a297-2867-4ef6-aa4b475c4e72@cs.ucla.edu>
On 13/01/2021 16:25, Paul Eggert wrote:
> On 1/5/21 5:07 AM, Adhemerval Zanella wrote:
>> It seems that gnulib has added the proposed fix with
>> aed23714d60d91b2abc74be33635c32ddc5132b5 (done in 2005) and just recently
>> with a glibc merge with 67306f600fe6a3bcf3fbb6d8bf4b8953b74a8fb7 (done in
>> 2020 to sync back glibc changes) it has fallback to old semantic to return
>> -1 on in case of failure.
>>
>> I am not sure if gnulib was intentional or an overlook.
>
> It was an oversight. I simply missed the issue when I did the merge.
>
>> I have started to check the feasibility or making the Rich suggestions at
>> comment #7,
>
> That's the right way to go. I would not spend much time trying to fix the bugs in the existing code. We should rip out all the wide-char stuff, treat encoding errors as if they were just another "character" (that's what Emacs does), and stay in the multibyte world. We could steal some ideas from Emacs here.
I think we still should fix BZ#14185 with the suggested with the strategy of
falling back to non wide mode in case of encoding error.
The full fix will take some time, since it is pretty much a rewrite of the
fnmatch_loop.c.
>
> By the way, how important is it to support awful encodings like shift-JIS that contain bytes that look like '\'? If we don't have to support these encodings any more, things get a bit easier. (Asking for a friend. :-)
next prev parent reply other threads:[~2021-01-14 11:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 20:25 [PATCH 1/2] posix: User scratch_buffer on fnmatch Adhemerval Zanella
2021-01-04 20:25 ` [PATCH 2/2] posix: Remove alloca usage for internal fnmatch implementation Adhemerval Zanella
2021-03-08 12:59 ` Florian Weimer
2021-10-20 15:12 ` Adhemerval Zanella
2021-10-21 9:54 ` Florian Weimer
2021-01-04 20:35 ` [PATCH 1/2] posix: User scratch_buffer on fnmatch Florian Weimer
2021-01-05 13:07 ` Adhemerval Zanella
2021-01-13 19:25 ` Paul Eggert
2021-01-13 19:39 ` Florian Weimer
2021-01-13 23:36 ` Bruno Haible
2021-01-14 10:00 ` Florian Weimer
2021-03-06 17:18 ` Paul Eggert
2021-03-06 20:17 ` dealing with non-ASCII-safe encodings Bruno Haible
2021-01-14 11:44 ` Adhemerval Zanella [this message]
2021-01-15 6:56 ` [PATCH 1/2] posix: User scratch_buffer on fnmatch Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e52b7836-5e6a-5f76-317c-1041ee392a2b@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=bug-gnulib@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).