From: Eric Blake <eblake@redhat.com>
To: Bruno Haible <bruno@clisp.org>, bug-gnulib@gnu.org
Subject: Re: [PATCH] configmake: Avoid namespace pollution issue on mingw.
Date: Sat, 10 Aug 2019 16:18:57 -0500 [thread overview]
Message-ID: <c56d14b1-7d27-6751-88d0-a1bcb86caadd@redhat.com> (raw)
In-Reply-To: <2125553.Pxj7dE0gMK@omega>
[-- Attachment #1.1: Type: text/plain, Size: 688 bytes --]
On 8/10/19 3:17 PM, Bruno Haible wrote:
> Hi Eric,
>
>> I've tested that this will fix the issue originally reported by
>> libvirt.
>
> So, does it fix the problem always?
>
> If yes, the instruction
> /* Include only after all system include files. */
> can be removed from the module description.
Will do.
>
> If no, we should add this instruction also to the documentation file
> doc/configmake.texi, so that users don't miss it.
If the problem recurs for some other combination of headers, we can
address it at that time.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-08-10 21:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 12:04 [PATCH] configmake: Avoid namespace pollution issue on mingw Eric Blake
2019-08-10 20:17 ` Bruno Haible
2019-08-10 21:18 ` Eric Blake [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-08-08 12:30 Eric Blake
2019-08-08 13:07 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c56d14b1-7d27-6751-88d0-a1bcb86caadd@redhat.com \
--to=eblake@redhat.com \
--cc=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).