From: Eric Blake <eblake@redhat.com>
To: bug-gnulib@gnu.org
Subject: Re: [PATCH] configmake: Avoid namespace pollution issue on mingw.
Date: Thu, 8 Aug 2019 08:07:55 -0500 [thread overview]
Message-ID: <c1b6d2d0-d407-1799-1fb2-adb39bee3721@redhat.com> (raw)
In-Reply-To: <20190808123006.5785-1-eblake@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 1045 bytes --]
On 8/8/19 7:30 AM, Eric Blake wrote:
> Mingw includes a header that declares a struct typedef named DATADIR,
> pulled in when including <winsock2.h>; compilation fails if DATADIR
> has already been defined as a macro expanding to a string prior to
> that inclusion. Although the configmake module documents that it
> should generally be included only after system headers, it is just as
> easy to make configmake.h robust to this particular issue by including
> the system header first if it exists.
>
> * modules/configmake (Makefile.am): If the project uses
> <winsock2.h>, include that header before defining DATADIR.
> Reported by libvirt: https://lists.gnu.org/archive/html/bug-gnulib/2019-07/msg00089.html
> ---
>
> I'm pushing this under the gnulib maintenance rule, while working on
> a further gnulib change to make configmake.h nicer on mingw.
Sorry, wrong list. Ignore this mail.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-08-08 13:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 12:30 [PATCH] configmake: Avoid namespace pollution issue on mingw Eric Blake
2019-08-08 13:07 ` Eric Blake [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-08-08 12:04 Eric Blake
2019-08-10 20:17 ` Bruno Haible
2019-08-10 21:18 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1b6d2d0-d407-1799-1fb2-adb39bee3721@redhat.com \
--to=eblake@redhat.com \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).