[PATCH silence -Wdeprecation-warning for sprintf on macOS] silence sprintf deprecation warning

[PATCH silence -Wdeprecation-warning for sprintf on macOS] silence sprintf deprecation warning

[Minsoo Choo]

---
sprintf is deprecated on macOS. Silence this warning by silencing
-Wdeprecated-declartions.

#if __GUNC__ >= 3 && defined(__APPLE__)
can be used as alternative if we don't want to disable this warning on
every system.

 lib/vasnprintf.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/vasnprintf.c b/lib/vasnprintf.c
index 01d18bf59..577dbbcd3 100644
--- a/lib/vasnprintf.c
+++ b/lib/vasnprintf.c
@@ -68,6 +68,11 @@
 # pragma GCC diagnostic ignored "-Wanalyzer-null-argument"
 #endif
 
+/* Using sprintf here is safe. Silence -Wdeprecated-declartions warning. */
+#if __GNUC__ >= 3
+# pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+#endif
+
 #include <alloca.h>
 
 /* Specification.  */

base-commit: 6ec9bc73686fd42d0a1a82c914d89176745cddbd
-- 
2.37.1 (Apple Git-137.1)

Re: [PATCH silence -Wdeprecation-warning for sprintf on macOS] silence sprintf deprecation warning

[Bruno Haible]

Minsoo Choo wrote:
> sprintf is deprecated on macOS. Silence this warning by silencing
> -Wdeprecated-declartions.

I don't get a warning by compiling the 'vasnprintf-posix' module
on macOS 12.6, even with -Wall -Wdeprecated-declarations.

What OS are you on, what are you compiling, and what are the values
for CC, CFLAGS, and CPPFLAGS that you have provided?

Bruno

Re: [PATCH silence -Wdeprecation-warning for sprintf on macOS] silence sprintf deprecation warning

[Sam James]

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]



> On 25 Nov 2022, at 22:25, Bruno Haible <bruno@clisp.org> wrote:
> 
> Minsoo Choo wrote:
>> sprintf is deprecated on macOS. Silence this warning by silencing
>> -Wdeprecated-declartions.
> 
> I don't get a warning by compiling the 'vasnprintf-posix' module
> on macOS 12.6, even with -Wall -Wdeprecated-declarations.
> 
> What OS are you on, what are you compiling, and what are the values
> for CC, CFLAGS, and CPPFLAGS that you have provided?

13.0 is needed - see https://lists.gnu.org/archive/html/bug-gnulib/2022-11/msg00013.html.

> 
> Bruno
> 

[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 358 bytes --]

Re: [PATCH silence -Wdeprecation-warning for sprintf on macOS] silence sprintf deprecation warning

[Paul Eggert]

On 2022-11-24 18:28, Minsoo Choo wrote:
> sprintf is deprecated on macOS. Silence this warning by silencing
> -Wdeprecated-declartions.

Surely this sort of thing should be done by a single change to the stdio 
module (e.g., editing lib/stdio.in.h), not by changing every module that 
calls sprintf.

Re: [PATCH silence -Wdeprecation-warning for sprintf on macOS] silence sprintf deprecation warning

[Minsoo Choo]

Sent with Proton Mail secure email.

------- Original Message -------
On Friday, November 25th, 2022 at 5:25 PM, Bruno Haible <bruno@clisp.org> wrote:


> Minsoo Choo wrote:
> 
> > sprintf is deprecated on macOS. Silence this warning by silencing
> > -Wdeprecated-declartions.
> 
> 
> I don't get a warning by compiling the 'vasnprintf-posix' module
> on macOS 12.6, even with -Wall -Wdeprecated-declarations.
> 
> What OS are you on, what are you compiling, and what are the values
> for CC, CFLAGS, and CPPFLAGS that you have provided?
> 
> Bruno
> 


I am using macOS 13.0.1(darwin 22.1.0). I used clang, which is the default compiler on macOS. I haven't set any specific CFLAGS/CPPFLAGS and build through './bootstrap && ./configure && ./make -j12'