From: Paul Eggert <eggert@cs.ucla.edu>
To: Ondrej Valousek <ondrej.valousek.xm@renesas.com>,
Bruno Haible <bruno@clisp.org>,
"bug-gnulib@gnu.org" <bug-gnulib@gnu.org>
Subject: Re: [PATCH] Basic support for checking NFSv4 ACLs in Linux
Date: Sun, 30 Oct 2022 11:36:44 -0700 [thread overview]
Message-ID: <ad33a5e5-1776-0917-e41e-e25e32cd7996@cs.ucla.edu> (raw)
In-Reply-To: <TYXPR01MB18542D6569B07BD6FE8B00F0D9329@TYXPR01MB1854.jpnprd01.prod.outlook.com>
On 2022-10-28 07:33, Ondrej Valousek wrote:
> 2. The 'acl' package (as of today) only supports Posix ACLs and not the NFSv4 style. And besides, we do not use it anyway on modern Linux distros - see the code, instead of calling acl library, we just call getxattr() function directly.
Is that the best we can do? Surely we shouldn't expect user code to
contain gems like this:
u_int32_t num_aces = (u_int32_t)ntohl(*((u_int32_t*)(xattr))); /* Grab
the number of aces in the acl
Wouldn't it be better to put this sort of thing into a library with a
well-defined API (you can call it "nfsacl" if you like) and have Gnulib
use that library? Gnulib is supposed to be a portability library, not a
packet sniffer.
next prev parent reply other threads:[~2022-10-30 18:37 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 9:34 [PATCH] Basic support for checking NFSv4 ACLs in Linux Ondrej Valousek
2022-10-27 19:52 ` Bruno Haible
2022-10-28 14:33 ` Ondrej Valousek
2022-10-30 18:36 ` Paul Eggert [this message]
2022-10-31 8:05 ` Ondrej Valousek
2022-10-31 19:36 ` Paul Eggert
2022-11-07 12:45 ` Ondrej Valousek
2022-11-08 22:11 ` Andreas Grünbacher
-- strict thread matches above, loose matches on Subject: below --
2022-11-09 15:32 Ondrej Valousek
[not found] <20221109152951.1003859-1-ondrej.valousek.xm@renesas.com>
[not found] ` <CAHpGcM+=+9Qp1umqzmP-aXHbEPtu8xB_hYP6kNk8UY52WOXpKA@mail.gmail.com>
[not found] ` <TY1PR01MB1850006B3019A6BA823B5859D9019@TY1PR01MB1850.jpnprd01.prod.outlook.com>
[not found] ` <CAHpGcMKSM7Sgc3jnexdRSajFhC8q0pTcg+M7LNpJs8cMRBgjqQ@mail.gmail.com>
2022-11-11 8:40 ` Ondrej Valousek
2022-11-13 19:32 ` Paul Eggert
2022-11-14 8:16 Ondrej Valousek
2022-11-14 12:49 ` Andreas Grünbacher
2022-11-15 9:17 ` Ondrej Valousek
2022-11-15 12:24 ` Andreas Grünbacher
2022-11-15 12:35 ` Andreas Grünbacher
2022-11-15 12:46 ` Ondrej Valousek
2022-11-15 13:14 ` Andreas Grünbacher
2022-11-16 9:51 ` Ondrej Valousek
2022-11-15 2:45 ` Paul Eggert
2022-11-15 7:00 ` Andreas Grünbacher
2022-11-24 17:08 Ondrej Valousek
2022-11-25 2:46 ` Bruno Haible
2022-11-25 9:34 ` Andreas Grünbacher
2022-11-25 10:17 ` Andreas Grünbacher
2022-11-28 7:29 ` Ondrej Valousek
2022-11-29 10:58 ` Andreas Grünbacher
2022-12-01 9:50 Ondrej Valousek
2022-12-01 11:52 ` Bruno Haible
2022-12-01 14:24 Ondrej Valousek
2022-12-02 0:58 ` Bruno Haible
2022-12-02 12:40 Ondrej Valousek
2022-12-02 13:33 ` Bruno Haible
2022-12-22 17:04 ` Bruno Haible
2022-12-23 23:32 ` Paul Eggert
2022-12-24 13:00 ` Ondrej Valousek
2022-12-24 19:27 ` Paul Eggert
2022-12-28 4:13 ` Paul Eggert
2022-12-28 9:07 ` Ondrej Valousek
2022-12-28 17:09 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad33a5e5-1776-0917-e41e-e25e32cd7996@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
--cc=ondrej.valousek.xm@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).