From: Dylan Cali <calid1984@gmail.com>
To: bug-gnulib@gnu.org
Subject: compile warnings when including avltree-list and gcc-warnings is enabled
Date: Fri, 5 Sep 2014 09:37:18 -0500 [thread overview]
Message-ID: <CAM1XmN8g0cYFz9GMPAxP6XM494d0dtS3nnoLxVNOB_WX8=1LGw@mail.gmail.com> (raw)
Hello,
After adding a couple gnulib modules to coreutils I get several
warnings. As a result, make fails since -Werror is enabled by
default. If I configure with --disable-gcc-warnings then the warnings
go away. The culprit seems to be avltree-list:
diff --git bootstrap.conf bootstrap.conf
index c0b5f02..a362376 100644
--- bootstrap.conf
+++ bootstrap.conf
@@ -34,6 +34,7 @@ gnulib_modules="
argv-iter
assert
autobuild
+ avltree-list
backupfile
base64
buffer-lcm
@@ -268,6 +269,7 @@ gnulib_modules="
xgetcwd
xgetgroups
xgethostname
+ xlist
xmemcoll
xnanosleep
xprintf
lib/gl_avltree_list.c:63:1: error: no previous declaration for
'gl_avltree_list_check_invariants' [-Werror=missing-declarations]
gl_avltree_list_check_invariants (gl_list_t list)
^
In file included from lib/gl_avltree_list.c:37:0:
lib/gl_avltree_list.c: In function 'gl_tree_next_node'
lib/gl_anytree_list2.h:104:1: error: function might be candidate for
attribute 'pure' if it is known to return normally
[-Werror=suggest-attribute=pure]
gl_tree_next_node (gl_list_t list, gl_list_node_t node)
^
lib/gl_avltree_list.c: In function 'gl_tree_previous_node'
lib/gl_anytree_list2.h:122:1: error: function might be candidate for
attribute 'pure' if it is known to return normally
[-Werror=suggest-attribute=pure]
gl_tree_previous_node (gl_list_t list, gl_list_node_t node)
^
lib/gl_avltree_list.c: In function 'node_at'
lib/gl_anytree_list2.h:141:1: error: function might be candidate for
attribute 'pure' if it is known to return normally
[-Werror=suggest-attribute=pure]
node_at (gl_list_node_t root, size_t position)
^
lib/gl_avltree_list.c: In function 'check_invariants'
lib/gl_avltree_list.c:41:1: error: function might be candidate for
attribute 'pure' if it is known to return normally
[-Werror=suggest-attribute=pure]
check_invariants (gl_list_node_t node, gl_list_node_t parent)
^
In file included from lib/gl_avltree_list.c:37:0:
lib/gl_avltree_list.c: In function 'gl_tree_get_at'
lib/gl_anytree_list2.h:166:1: error: function might be candidate for
attribute 'pure' if it is known to return normally
[-Werror=suggest-attribute=pure]
gl_tree_get_at (gl_list_t list, size_t position)
^
lib/gl_avltree_list.c: In function 'gl_avltree_list_check_invariants'
lib/gl_avltree_list.c:63:1: error: function might be candidate for
attribute 'pure' if it is known to return normally
[-Werror=suggest-attribute=pure]
gl_avltree_list_check_invariants (gl_list_t list)
^
Let me know if you need any further information.
Thanks,
Dylan
next reply other threads:[~2014-09-05 15:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 14:37 Dylan Cali [this message]
2014-09-05 15:51 ` compile warnings when including avltree-list and gcc-warnings is enabled Paul Eggert
2014-09-05 16:11 ` Dylan Cali
2014-09-06 7:05 ` Dylan Cali
2014-09-07 0:30 ` Paul Eggert
2014-09-07 1:42 ` Dylan Cali
2014-09-08 14:27 ` Eric Blake
2014-09-08 15:04 ` Dylan Cali
2014-09-08 23:09 ` Dylan Cali
2014-09-16 16:05 ` Pádraig Brady
2019-09-29 14:39 ` Bruno Haible
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM1XmN8g0cYFz9GMPAxP6XM494d0dtS3nnoLxVNOB_WX8=1LGw@mail.gmail.com' \
--to=calid1984@gmail.com \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).