From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.0.0.0/16 X-Spam-Status: No, score=-2.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,SPF_SOFTFAIL shortcircuit=no autolearn=no autolearn_force=no version=3.4.0 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XPvOB-0006hl-4b for mharc-bug-gnulib@gnu.org; Fri, 05 Sep 2014 11:25:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPudg-0001tm-0G for bug-gnulib@gnu.org; Fri, 05 Sep 2014 10:37:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPude-0006Is-LW for bug-gnulib@gnu.org; Fri, 05 Sep 2014 10:37:23 -0400 Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]:53464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPude-0006In-Cm for bug-gnulib@gnu.org; Fri, 05 Sep 2014 10:37:22 -0400 Received: by mail-wi0-f169.google.com with SMTP id n3so884864wiv.2 for ; Fri, 05 Sep 2014 07:37:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=2d+VIqaig27Yakvjr0vfsCn0PD7Yq9xLWWsOQgC/gss=; b=wXlsqoDeqzn2PrQrY8ZcXwpwOmPOWcV4bQ32QZbO7NuzwjaJvcrPVSut/wghMSVFcW x2iSX3d8a656C/oXTrbWz3C6rLxMh7ratCnuGpoKxCFM6DXsp6ZyMwI4xZiB8QBm/xPj dyQztfGp3EXgoOT78U9xI6bEzxhDjShVG9DNRor7xhccmq53i1kjV8ysAG9EKNek9SXn oSWK7HbKnWIM89Jf12Fz7eS9IhD/eg85zOgcaWuiTFTFZW2JBC4xpxe2TeY+f2U4SJVO lIif6pdUyiGoeoKxZyxdziOSwtCDBu5tcH92rirazDxku2/pSkAuXYdb1zh/BxdPQxrG B/Eg== MIME-Version: 1.0 X-Received: by 10.180.37.108 with SMTP id x12mr4460582wij.16.1409927838190; Fri, 05 Sep 2014 07:37:18 -0700 (PDT) Received: by 10.194.246.36 with HTTP; Fri, 5 Sep 2014 07:37:18 -0700 (PDT) Date: Fri, 5 Sep 2014 09:37:18 -0500 Message-ID: Subject: compile warnings when including avltree-list and gcc-warnings is enabled From: Dylan Cali To: bug-gnulib@gnu.org Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::229 X-Mailman-Approved-At: Fri, 05 Sep 2014 11:25:26 -0400 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Sep 2014 14:37:25 -0000 Hello, After adding a couple gnulib modules to coreutils I get several warnings. As a result, make fails since -Werror is enabled by default. If I configure with --disable-gcc-warnings then the warnings go away. The culprit seems to be avltree-list: diff --git bootstrap.conf bootstrap.conf index c0b5f02..a362376 100644 --- bootstrap.conf +++ bootstrap.conf @@ -34,6 +34,7 @@ gnulib_modules=" argv-iter assert autobuild + avltree-list backupfile base64 buffer-lcm @@ -268,6 +269,7 @@ gnulib_modules=" xgetcwd xgetgroups xgethostname + xlist xmemcoll xnanosleep xprintf lib/gl_avltree_list.c:63:1: error: no previous declaration for 'gl_avltree_list_check_invariants' [-Werror=missing-declarations] gl_avltree_list_check_invariants (gl_list_t list) ^ In file included from lib/gl_avltree_list.c:37:0: lib/gl_avltree_list.c: In function 'gl_tree_next_node' lib/gl_anytree_list2.h:104:1: error: function might be candidate for attribute 'pure' if it is known to return normally [-Werror=suggest-attribute=pure] gl_tree_next_node (gl_list_t list, gl_list_node_t node) ^ lib/gl_avltree_list.c: In function 'gl_tree_previous_node' lib/gl_anytree_list2.h:122:1: error: function might be candidate for attribute 'pure' if it is known to return normally [-Werror=suggest-attribute=pure] gl_tree_previous_node (gl_list_t list, gl_list_node_t node) ^ lib/gl_avltree_list.c: In function 'node_at' lib/gl_anytree_list2.h:141:1: error: function might be candidate for attribute 'pure' if it is known to return normally [-Werror=suggest-attribute=pure] node_at (gl_list_node_t root, size_t position) ^ lib/gl_avltree_list.c: In function 'check_invariants' lib/gl_avltree_list.c:41:1: error: function might be candidate for attribute 'pure' if it is known to return normally [-Werror=suggest-attribute=pure] check_invariants (gl_list_node_t node, gl_list_node_t parent) ^ In file included from lib/gl_avltree_list.c:37:0: lib/gl_avltree_list.c: In function 'gl_tree_get_at' lib/gl_anytree_list2.h:166:1: error: function might be candidate for attribute 'pure' if it is known to return normally [-Werror=suggest-attribute=pure] gl_tree_get_at (gl_list_t list, size_t position) ^ lib/gl_avltree_list.c: In function 'gl_avltree_list_check_invariants' lib/gl_avltree_list.c:63:1: error: function might be candidate for attribute 'pure' if it is known to return normally [-Werror=suggest-attribute=pure] gl_avltree_list_check_invariants (gl_list_t list) ^ Let me know if you need any further information. Thanks, Dylan