bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: "Marc Nieper-Wißkirchen" <marc.nieper+gnu@gmail.com>
To: Bruno Haible <bruno@clisp.org>
Cc: "Marc Nieper-Wißkirchen" <marc.nieper+gnu@gmail.com>, bug-gnulib@gnu.org
Subject: Re: stack module
Date: Sat, 10 Oct 2020 16:35:32 +0200	[thread overview]
Message-ID: <CAEYrNrTbU3a-=LSoC+SyM6LS84SML1tGwRy=qDpXW0MZQpYVeQ@mail.gmail.com> (raw)
In-Reply-To: <5345689.MaH1usZXot@omega>

Hi Bruno,

Am Sa., 10. Okt. 2020 um 16:06 Uhr schrieb Bruno Haible <bruno@clisp.org>:
>
> Hi Marc,
>
> > please see the attached patch for the new module.
>
> Very nice. Looks all good, except for some nit-picking in the comments:

Thanks.

>
> > +     Introspection:      ELEMENT *base = stack_base (&stack);
>
> I would add a comment here:
>   Where ELEMENT is the type to which GL_STACK_ELEMENT was defined when
>   this file was included.
> (It would be tempting to write
>     GL_STACK_ELEMENT *base = stack_base (&stack);
> but GL_STACK_ELEMENT is no longer defined after the file was included...)

I will add this comment.

> Other than that, please feel free to commit and push this. Thanks!!

I will do this as soon as I have been approved by Paul. (Do I have to
do something about the ChangeLog entry or will it be auto-generated
from my Git commit message?)

Marc


  reply	other threads:[~2020-10-10 14:36 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28  7:08 Add gl_list_remove_last to list/xlist Marc Nieper-Wißkirchen
2020-05-02  0:07 ` Bruno Haible
2020-05-02  7:16   ` Marc Nieper-Wißkirchen
2020-05-02 12:07     ` Bruno Haible
2020-05-02 12:49       ` Marc Nieper-Wißkirchen
2020-05-02 15:49         ` Bruno Haible
2020-05-02 16:04           ` Marc Nieper-Wißkirchen
2020-05-22 15:59           ` Marc Nieper-Wißkirchen
2020-05-23 12:30             ` stack module Bruno Haible
2020-05-23 12:42               ` Marc Nieper-Wißkirchen
2020-05-23 14:02                 ` Bruno Haible
2020-05-23 14:36                   ` Marc Nieper-Wißkirchen
2020-05-23 15:39                     ` Paul Eggert
2020-05-23 15:55                       ` Marc Nieper-Wißkirchen
2020-05-23 16:44                         ` Paul Eggert
2020-05-23 16:54                           ` Marc Nieper-Wißkirchen
2020-05-23 17:33                             ` Paul Eggert
2020-05-23 17:38                               ` Marc Nieper-Wißkirchen
2020-05-23 20:51                                 ` Paul Eggert
2020-05-23 21:07                                   ` Marc Nieper-Wißkirchen
2020-05-23 22:06                                   ` Bruno Haible
2020-05-24  2:14                                     ` Paul Eggert
2020-05-24  8:17                                       ` Marc Nieper-Wißkirchen
2020-05-24 19:07                                         ` Paul Eggert
2020-05-24 19:26                                           ` Bruno Haible
2020-06-02 13:44                                             ` Marc Nieper-Wißkirchen
2020-05-23 17:19                     ` Bruno Haible
2020-07-22 20:17                       ` Marc Nieper-Wißkirchen
2020-07-23 10:36                         ` Bruno Haible
2020-07-23 10:56                           ` Marc Nieper-Wißkirchen
2020-10-07  9:01                           ` Marc Nieper-Wißkirchen
2020-10-07 11:31                             ` Marc Nieper-Wißkirchen
2020-10-10 14:06                               ` Bruno Haible
2020-10-10 14:35                                 ` Marc Nieper-Wißkirchen [this message]
2020-10-10 15:10                                   ` ChangeLog entries Bruno Haible
2020-05-02 21:24       ` Add gl_list_remove_last to list/xlist Bruno Haible
2020-05-03 11:14         ` Bruno Haible
2020-05-05  8:37         ` Marc Nieper-Wißkirchen
2020-05-08 17:28           ` Bruno Haible
2020-06-03 16:32         ` Marc Nieper-Wißkirchen
2020-06-03 21:08           ` Bruno Haible
2020-06-03 21:22             ` Marc Nieper-Wißkirchen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEYrNrTbU3a-=LSoC+SyM6LS84SML1tGwRy=qDpXW0MZQpYVeQ@mail.gmail.com' \
    --to=marc.nieper+gnu@gmail.com \
    --cc=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).