From: "Marc Nieper-Wißkirchen" <marc.nieper+gnu@gmail.com>
To: Bruno Haible <bruno@clisp.org>
Cc: "Marc Nieper-Wißkirchen" <marc.nieper+gnu@gmail.com>, bug-gnulib@gnu.org
Subject: Re: Add gl_list_remove_last to list/xlist
Date: Wed, 3 Jun 2020 18:32:59 +0200 [thread overview]
Message-ID: <CAEYrNrSyW7pWdwP-TfQjpnSO78xycz8kwdL+VBs0Xi5MJx8Vfw@mail.gmail.com> (raw)
In-Reply-To: <4261612.ILBSuMgyWs@omega>
Hi Bruno,
now that some operations together with their complexity for dealing
with the end of the list have been added, what do you think of adding
a reverse iterator?
Thanks,
Marc
PS I've received a reply by the FSF; now I am waiting for the response
by my university's lawyer.
Am Sa., 2. Mai 2020 um 23:24 Uhr schrieb Bruno Haible <bruno@clisp.org>:
>
> I wrote:
> > I should better revert yesterday's patch, and instead,
> > in the table show the guaranteed average performance
> > gl_list_get_first
> > gl_list_get_last
> > gl_list_set_first
> > gl_list_set_last
> > gl_list_remove_first
> > gl_list_remove_last
> > where these 6 functions are defined globally, not separately for each
> > implementation.
>
> Done through the two attached patches.
>
> 2020-05-02 Bruno Haible <bruno@clisp.org>
>
> list: Add get_first, get_last, set_first, set_last operations.
> * lib/gl_list.h (gl_list_get_first, gl_list_get_last,
> gl_list_nx_set_first, gl_list_nx_set_last): New functions.
> * lib/gl_xlist.h (gl_list_set_first, gl_list_set_last): New functions.
>
> 2020-05-02 Bruno Haible <bruno@clisp.org>
>
> list: Remove redundant code for remove_first and remove_last operations.
> * lib/gl_list.h (struct gl_list_implementation): Remove fields
> remove_first, remove_last.
> (gl_list_remove_first, gl_list_remove_last): Implement in a generic way.
> * lib/gl_array_list.c: Revert last change.
> * lib/gl_carray_list.c: Likewise.
> * lib/gl_anylinked_list2.h: Likewise.
> * lib/gl_linked_list.c: Likewise.
> * lib/gl_linkedhash_list.c: Likewise.
> * lib/gl_anytree_list2.h: Likewise.
> * lib/gl_avltree_list.c: Likewise.
> * lib/gl_avltreehash_list.c: Likewise.
> * lib/gl_rbtree_list.c: Likewise.
> * lib/gl_rbtreehash_list.c: Likewise.
> * lib/gl_sublist.c: Likewise.
>
next prev parent reply other threads:[~2020-06-03 16:35 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 7:08 Add gl_list_remove_last to list/xlist Marc Nieper-Wißkirchen
2020-05-02 0:07 ` Bruno Haible
2020-05-02 7:16 ` Marc Nieper-Wißkirchen
2020-05-02 12:07 ` Bruno Haible
2020-05-02 12:49 ` Marc Nieper-Wißkirchen
2020-05-02 15:49 ` Bruno Haible
2020-05-02 16:04 ` Marc Nieper-Wißkirchen
2020-05-22 15:59 ` Marc Nieper-Wißkirchen
2020-05-23 12:30 ` stack module Bruno Haible
2020-05-23 12:42 ` Marc Nieper-Wißkirchen
2020-05-23 14:02 ` Bruno Haible
2020-05-23 14:36 ` Marc Nieper-Wißkirchen
2020-05-23 15:39 ` Paul Eggert
2020-05-23 15:55 ` Marc Nieper-Wißkirchen
2020-05-23 16:44 ` Paul Eggert
2020-05-23 16:54 ` Marc Nieper-Wißkirchen
2020-05-23 17:33 ` Paul Eggert
2020-05-23 17:38 ` Marc Nieper-Wißkirchen
2020-05-23 20:51 ` Paul Eggert
2020-05-23 21:07 ` Marc Nieper-Wißkirchen
2020-05-23 22:06 ` Bruno Haible
2020-05-24 2:14 ` Paul Eggert
2020-05-24 8:17 ` Marc Nieper-Wißkirchen
2020-05-24 19:07 ` Paul Eggert
2020-05-24 19:26 ` Bruno Haible
2020-06-02 13:44 ` Marc Nieper-Wißkirchen
2020-05-23 17:19 ` Bruno Haible
2020-07-22 20:17 ` Marc Nieper-Wißkirchen
2020-07-23 10:36 ` Bruno Haible
2020-07-23 10:56 ` Marc Nieper-Wißkirchen
2020-10-07 9:01 ` Marc Nieper-Wißkirchen
2020-10-07 11:31 ` Marc Nieper-Wißkirchen
2020-10-10 14:06 ` Bruno Haible
2020-10-10 14:35 ` Marc Nieper-Wißkirchen
2020-10-10 15:10 ` ChangeLog entries Bruno Haible
2020-05-02 21:24 ` Add gl_list_remove_last to list/xlist Bruno Haible
2020-05-03 11:14 ` Bruno Haible
2020-05-05 8:37 ` Marc Nieper-Wißkirchen
2020-05-08 17:28 ` Bruno Haible
2020-06-03 16:32 ` Marc Nieper-Wißkirchen [this message]
2020-06-03 21:08 ` Bruno Haible
2020-06-03 21:22 ` Marc Nieper-Wißkirchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEYrNrSyW7pWdwP-TfQjpnSO78xycz8kwdL+VBs0Xi5MJx8Vfw@mail.gmail.com \
--to=marc.nieper+gnu@gmail.com \
--cc=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).