Re: [platform-testers] new snapshot available: grep-3.4-almost.19-ff30

[Jim Meyering <jim@meyering.net>]

[-- Attachment #1: Type: text/plain, Size: 702 bytes --]

On Thu, Sep 17, 2020 at 6:37 AM Jeffrey Walton <noloader@gmail.com> wrote:
> Hi Everyone,
>
> grep-3.4-almost.19-ff30 fails self test on Alpine Linux 3.10 with
> BusyBox, triplet x86_64-pc-linux-gnu.
>
>   FAIL: test-dfa-match.sh

Thank you for reporting that. I'll start with that first issue.
That is due to a now-erroneous test for busybox-specific timeout
program which used to require "-t" before the timeout value.
Now, it has aligned with coreutils, since the 31 December 2018 release
of BusyBox 1.30.0 (unstable).
I've fixed it with the attached patch, also just pushed to gnulib.

>   FAIL: test-hard-locale
>   FAIL: test-setlocale_null-mt-all
>
> Attached are config.log and test-suite.log.

[-- Attachment #2: test-dfa-match.sh--busybox-vs-timeout.patch --]
[-- Type: application/octet-stream, Size: 1461 bytes --]

From d7d69621581065274582c78981b58dbce4313d2c Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@fb.com>
Date: Thu, 17 Sep 2020 07:36:26 -0700
Subject: [PATCH] test-dfa-match.sh: port timeout work-around to newer Busybox

* tests/test-dfa-match.sh: Update timeout -t portability test to
accommodate Busybox 1.30.0 and newer.
---
 ChangeLog               | 6 ++++++
 tests/test-dfa-match.sh | 4 +++-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index bbd420cb2..e5b50bf55 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2020-09-17  Jim Meyering  <meyering@fb.com>
+
+	test-dfa-match.sh: port timeout work-around to newer Busybox
+	* tests/test-dfa-match.sh: Update timeout -t portability test to
+	accommodate Busybox 1.30.0 and newer.
+
 2020-09-16  Paul Eggert  <eggert@cs.ucla.edu>

 	fnmatch: adjust to match glibc fix
diff --git a/tests/test-dfa-match.sh b/tests/test-dfa-match.sh
index a7285ec0b..d3c434d66 100755
--- a/tests/test-dfa-match.sh
+++ b/tests/test-dfa-match.sh
@@ -22,7 +22,9 @@
 path_prepend_ .

 if (type timeout) >/dev/null 2>&1; then
-  if timeout --help 2>&1 | grep BusyBox; then
+    # Busybox's timeout required -t until its 1.30.0 release on 2018-12-31,
+    # after which it became compatible with coreutils' timeout.
+  if timeout --help 2>&1 | grep BusyBox && timeout -t 0 true; then
     timeout_10='timeout -t 10'
   else
     timeout_10='timeout 10'
-- 
2.28.0.394.ge197136389