From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Cc: Paul Eggert <eggert@cs.ucla.edu>
Subject: Re: grep-3.4-almost.19-ff30 on Solaris 10
Date: Fri, 18 Sep 2020 11:01:54 +0200 [thread overview]
Message-ID: <6160020.m44uqoBmH5@omega> (raw)
In-Reply-To: <8bd0613b-5c4c-9c82-6310-a9cd061e9c85@cs.ucla.edu>
Hi Paul,
> On 9/17/20 1:53 PM, Bruno Haible wrote:
> > - {
> > - $1
> > - } AS_MESSAGE_FD>/dev/null
> > + exec GL_TMP_FD>&AS_MESSAGE_FD AS_MESSAGE_FD>/dev/null
> > + $1
> > + exec AS_MESSAGE_FD>&GL_TMP_FD AS_MESSAGE_FD>&-
I had a typo in here. Corrected:
exec GL_TMP_FD>&AS_MESSAGE_FD AS_MESSAGE_FD>/dev/null
$1
exec AS_MESSAGE_FD>&GL_TMP_FD GL_TMP_FD>&-
Which expands to:
exec 9>&6 6>/dev/null
$1
exec 6>&9 9>&-
> If a trap occurs during $1 and 'configure' outputs something to stderr before it
> exits, the output could be lost due to this patch.
No, I don't think so. The file descriptor 2 is unaffected by the file descriptor
reshuffle. Only file descriptor 6 is affected, which is the one used by
AC_MSG_CHECKING/AC_MSG_RESULT. No one is supposed to use this file descriptor
in a 'trap' action.
> Looking into it further, gl_SILENT is iffy as a general macro, as discarding
> stderr could make scripts harder to debug.
I disagree. I want gl_SILENT for the purpose of doing more complex checks inside
an AC_CACHE_CHECK invocation. Without gl_SILENT, the message output dictates the
structure of the AC_CACHE_CHECKs. This is not good.
> Since gl_SILENT is used in just one place in Gnulib
signalblocking.m4 is only the first one. I want gl_SILENT also to clean up
the getaddrinfo output and others.
> fix the issue with gl_SIGNALBLOCKING and cached configuration variables.
While the gl_SIGNALBLOCKING patch is correct, it does not help solving the
general problem that gl_SILENT is meant to address.
Can you please restore it?
Bruno
next prev parent reply other threads:[~2020-09-18 9:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m2imce1gpu.fsf@meyering.net>
[not found] ` <CAH8yC8n4tmO6__C=zP0JZRmc5_ddg7L6uGAuLfjV_Bm+i3oYsA@mail.gmail.com>
2020-09-17 18:23 ` [platform-testers] new snapshot available: grep-3.4-almost.19-ff30 Paul Eggert
2020-09-17 20:53 ` grep-3.4-almost.19-ff30 on Solaris 10 Bruno Haible
2020-09-18 2:26 ` Paul Eggert
2020-09-18 9:01 ` Bruno Haible [this message]
2020-09-18 16:06 ` Paul Eggert
2020-09-19 0:25 ` gl_SILENT Bruno Haible
2020-09-17 21:07 ` [platform-testers] new snapshot available: grep-3.4-almost.19-ff30 Jeffrey Walton
2020-09-18 17:36 ` Paul Eggert
[not found] ` <CAH8yC8mn1YMN+fgzJBKEk9+y0qTqfO2zHbWUyO2ekVq-PimX3Q@mail.gmail.com>
2020-09-17 14:40 ` Jim Meyering
2020-09-17 22:46 ` Bruno Haible
2020-09-19 13:12 ` Bruno Haible
2020-09-19 14:21 ` Jeffrey Walton
2020-09-19 19:15 ` Bruno Haible
2020-09-20 19:28 ` Bruno Haible
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6160020.m44uqoBmH5@omega \
--to=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).