bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Jim Meyering <jim@meyering.net>
To: noloader@gmail.com
Cc: bug-libunistring@gnu.org,
	"bug-gnulib@gnu.org List" <bug-gnulib@gnu.org>,
	Bruno Haible <bruno@clisp.org>
Subject: Re: [bug-libunistring] Unistring 0.9.10 and Undefined Behavior sanitizer findings
Date: Sat, 9 Mar 2019 20:47:18 -0800	[thread overview]
Message-ID: <CA+8g5KF8SKT2GnvsHyd0gN6hPmbd03Ux3P_N7J6+wCcx9dP21A@mail.gmail.com> (raw)
In-Reply-To: <CAH8yC8=-CRnE3-Pb_Ug12FiyGoWrxW2VEn6=hr3J88MK0E8PNw@mail.gmail.com>

On Fri, Mar 8, 2019 at 5:30 PM Jeffrey Walton <noloader@gmail.com> wrote:

Thanks for the UBSAN testing and report, and to Bruno for all the fixes.

> On Fri, Mar 8, 2019 at 6:36 PM Bruno Haible <bruno@clisp.org> wrote:
> >  ...
> > I'm pushing the attached patches.
>
> Thanks Bruno, got them. 0.9.10 tested good with them.
>
> (I should be starting on -fsanitize=address this weekend. Address
> Sanitizer is a little trickier because I've seen findings that I could
> not explain or repro with Valgrind).

For some types of problems, that is expected: valgrind detects few
things (UMR is the one I miss the most. use MSAN for those if you can
manage to instrument all dependent libraries) that ASAN does not
catch. However, ASAN catches many types of bugs that valgrind cannot
detect.


      reply	other threads:[~2019-03-10  4:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAH8yC8kNZpPFZQdUD_brywwH75hyae=_Xsw=5MWgVQNjYfqMpg@mail.gmail.com>
2019-03-08 23:36 ` [bug-libunistring] Unistring 0.9.10 and Undefined Behavior sanitizer findings Bruno Haible
2019-03-09  1:29   ` Jeffrey Walton
2019-03-10  4:47     ` Jim Meyering [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+8g5KF8SKT2GnvsHyd0gN6hPmbd03Ux3P_N7J6+wCcx9dP21A@mail.gmail.com \
    --to=jim@meyering.net \
    --cc=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    --cc=bug-libunistring@gnu.org \
    --cc=noloader@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).