From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 4DFD920248 for ; Sun, 10 Mar 2019 04:47:41 +0000 (UTC) Received: from localhost ([127.0.0.1]:40051 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2qN9-0004oo-DN for normalperson@yhbt.net; Sat, 09 Mar 2019 23:47:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2qN5-0004nb-Mf for bug-gnulib@gnu.org; Sat, 09 Mar 2019 23:47:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h2qN5-0000cI-0e for bug-gnulib@gnu.org; Sat, 09 Mar 2019 23:47:35 -0500 Received: from mail-wm1-f43.google.com ([209.85.128.43]:38156) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h2qN3-0000Zm-6A; Sat, 09 Mar 2019 23:47:33 -0500 Received: by mail-wm1-f43.google.com with SMTP id a188so1237532wmf.3; Sat, 09 Mar 2019 20:47:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WlInQXlrS2gvJqIGK5N4Q1TCtpTT+1Ajf5PXR8JXhj0=; b=rFLRiEU+jHXn1TqCA2bCnqN2TNLsbvETKRaORJ/gJ705a+mVzLbcAbpdbzh3wHh8UV ZU+vI9IbqNZM51WU0+jBDunVzwL3T2taspFTsV+QqaL/WaO95UN48XgKMp5Ob/zkek8k q1AcKvHc/aWGymZwkNTvQw6yCXDBe37FHpFpup8sq+F67z1rpiTArbU/BUKcoFkVNAOW OQdXlfDAXun3Jbwtjipcfk4ImjTl7t4qtQc9RQ0XtxckPUrtCDO5xSNX+TRijB9s/+K8 CxSprL+P4HktJw1pgXbd1V2EmLt7CDa4U6oDzP8q52reV/ie9T9ge6tV8Yt4n7uCQESS zeCQ== X-Gm-Message-State: APjAAAVGgSGEnZlCGXS7/LGMeOuEbkAApA7yfgiF8qrPrOGGts7w/Tzc K33LCdziX/oHUAXl68Eiq2ZEklQQQgY6p4wLHmw= X-Google-Smtp-Source: APXvYqzsSqJ6QkVdq6VCXqIGGrX1godq/DcfxQjUCFnp2ma4pJy35AkWlMFbaUE4Br1yCCqc9APgACeuiF0MyP10Z3k= X-Received: by 2002:a1c:64c1:: with SMTP id y184mr13440778wmb.0.1552193251271; Sat, 09 Mar 2019 20:47:31 -0800 (PST) MIME-Version: 1.0 References: <1823565.3HqkIL8hjV@omega> In-Reply-To: From: Jim Meyering Date: Sat, 9 Mar 2019 20:47:18 -0800 Message-ID: Subject: Re: [bug-libunistring] Unistring 0.9.10 and Undefined Behavior sanitizer findings To: noloader@gmail.com Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.128.43 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bug-libunistring@gnu.org, "bug-gnulib@gnu.org List" , Bruno Haible Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" On Fri, Mar 8, 2019 at 5:30 PM Jeffrey Walton wrote: Thanks for the UBSAN testing and report, and to Bruno for all the fixes. > On Fri, Mar 8, 2019 at 6:36 PM Bruno Haible wrote: > > ... > > I'm pushing the attached patches. > > Thanks Bruno, got them. 0.9.10 tested good with them. > > (I should be starting on -fsanitize=address this weekend. Address > Sanitizer is a little trickier because I've seen findings that I could > not explain or repro with Valgrind). For some types of problems, that is expected: valgrind detects few things (UMR is the one I miss the most. use MSAN for those if you can manage to instrument all dependent libraries) that ASAN does not catch. However, ASAN catches many types of bugs that valgrind cannot detect.