From: Jim Meyering <jim@meyering.net>
To: Bruno Haible <bruno@clisp.org>
Cc: "bug-gnulib@gnu.org List" <bug-gnulib@gnu.org>
Subject: Re: [PATCH] stdlib: avoid canonicalize_file_name contradiction
Date: Sun, 5 Jan 2020 08:46:12 -0800 [thread overview]
Message-ID: <CA+8g5KEC5mCi_0uVRZJpJ4rjuHtiGioqbSnepMqQ177oLjP_qQ@mail.gmail.com> (raw)
In-Reply-To: <CA+8g5KGQ-z4_bSxPDbeh=CagLAEFDQRe9aOK2ZTs-abauH69_w@mail.gmail.com>
On Sun, Jan 5, 2020 at 8:41 AM Jim Meyering <jim@meyering.net> wrote:
...
> > Does the attached patch fix the problem for you?
>
> Thanks for working on that. However, it did not help, because at least
> on Fedora 30, we're using the system declaration, per this: (run from
> a test dir prepared by "./gnulib-tool --test --dir /tmp/x --with-tests
> canonicalize-lgpl", which still segfaults that test)
>
> $ rm test-canonicalize-lgpl.o
> $ make test-canonicalize-lgpl.o CFLAGS='-dD -E'
> ...
> $ grep -A2 ze_file test-canonicalize-lgpl.o|head -3
> extern char *canonicalize_file_name (const char *__name)
> __attribute__ ((__nothrow__ , __leaf__)) __attribute__
> ((__nonnull__ (1))) ;
> # 797 "/usr/include/stdlib.h" 3 4
This makes me suspect I did not test my own patch.
I've just confirmed that. My patch didn't help, either.
Sorry about that.
next prev parent reply other threads:[~2020-01-05 16:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-05 6:24 [PATCH] stdlib: avoid canonicalize_file_name contradiction Jim Meyering
2020-01-05 8:15 ` Bruno Haible
2020-01-05 16:41 ` Jim Meyering
2020-01-05 16:46 ` Jim Meyering [this message]
2020-01-05 20:46 ` Bruno Haible
2020-01-05 21:52 ` Jim Meyering
2020-01-05 22:57 ` Bruno Haible
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+8g5KEC5mCi_0uVRZJpJ4rjuHtiGioqbSnepMqQ177oLjP_qQ@mail.gmail.com \
--to=jim@meyering.net \
--cc=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).