From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C6C701F463 for ; Sun, 5 Jan 2020 16:46:40 +0000 (UTC) Received: from localhost ([::1]:43490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1io931-0004k6-W8 for normalperson@yhbt.net; Sun, 05 Jan 2020 11:46:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60319) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1io92p-0004jx-3E for bug-gnulib@gnu.org; Sun, 05 Jan 2020 11:46:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1io92n-0004bs-TT for bug-gnulib@gnu.org; Sun, 05 Jan 2020 11:46:26 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:40782) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1io92n-0004a9-Ni for bug-gnulib@gnu.org; Sun, 05 Jan 2020 11:46:25 -0500 Received: by mail-wr1-f65.google.com with SMTP id c14so47071635wrn.7 for ; Sun, 05 Jan 2020 08:46:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QQoJim6o7neumdol5ty2cXMwQ6QPrlfjT1Oo/Pw1gPw=; b=amxI7IhzZ4W8lQbfoGsO5DTahcKTL0aSVL9r8xDZ9enX/hBSl9N68AVmfgysrF4LV4 knaC2xUTXTqDJglWZhBm8Iy/20/5/TYENWTXisPD9EdMUkuJOR0XTl95p14fjNTABNx2 1lCpWKjsXotGC0EqMPipkDKi9rJ0idjlO0bFesR2eBgmEGbO2Ef2Oicv/D42djjwoxaC 77P/gJkqUY6PZTVAwp3kKvpc9HTtJOXAJBmpmF1e+o1G/yDSl7J0tLrfH1Wz9MYMjOkX 7uuvY2N9128MlNv5Upeob9TTVv0ttHB4SrqNaFGxj7tqPo+6UaWg8j6bUCw+iFeG6caK HRdw== X-Gm-Message-State: APjAAAUBgEzweDcY1dV93qQ7eNeHyATGXLbNuos83aQdQwHRGccH6NPR DiQDNk+sMTToRLgfdGB815lbr7zH0FK9rz8wlWJ+gg== X-Google-Smtp-Source: APXvYqxbjuQro99IsSxtEpavXLN/GBpLTd8I9XdJXMzMMi4hKNVxgYDUrzSbr2LCg/y9GmJVWzfIRhDbFGSWZV8pwxg= X-Received: by 2002:a5d:670a:: with SMTP id o10mr102965285wru.227.1578242784846; Sun, 05 Jan 2020 08:46:24 -0800 (PST) MIME-Version: 1.0 References: <4223468.KeoCiBS5fI@omega> In-Reply-To: From: Jim Meyering Date: Sun, 5 Jan 2020 08:46:12 -0800 Message-ID: Subject: Re: [PATCH] stdlib: avoid canonicalize_file_name contradiction To: Bruno Haible Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.221.65 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "bug-gnulib@gnu.org List" Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" On Sun, Jan 5, 2020 at 8:41 AM Jim Meyering wrote: ... > > Does the attached patch fix the problem for you? > > Thanks for working on that. However, it did not help, because at least > on Fedora 30, we're using the system declaration, per this: (run from > a test dir prepared by "./gnulib-tool --test --dir /tmp/x --with-tests > canonicalize-lgpl", which still segfaults that test) > > $ rm test-canonicalize-lgpl.o > $ make test-canonicalize-lgpl.o CFLAGS='-dD -E' > ... > $ grep -A2 ze_file test-canonicalize-lgpl.o|head -3 > extern char *canonicalize_file_name (const char *__name) > __attribute__ ((__nothrow__ , __leaf__)) __attribute__ > ((__nonnull__ (1))) ; > # 797 "/usr/include/stdlib.h" 3 4 This makes me suspect I did not test my own patch. I've just confirmed that. My patch didn't help, either. Sorry about that.