From: Simon Josefsson via Gnulib discussion list <bug-gnulib@gnu.org>
To: Simon Josefsson via Gnulib discussion list <bug-gnulib@gnu.org>
Subject: Re: [PATCH] valgrind-tests: Better option handling.
Date: Fri, 14 May 2021 15:07:16 +0200 [thread overview]
Message-ID: <87zgwxwjjv.fsf@latte.josefsson.org> (raw)
In-Reply-To: <87lf8hxzxx.fsf@latte.josefsson.org> (Simon Josefsson via Gnulib discussion list's message of "Fri, 14 May 2021 14:27:54 +0200")
[-- Attachment #1.1: Type: text/plain, Size: 59 bytes --]
Further testing quickly found a small bug, pushed.
/Simon
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-valgrind-tests-Fix-LOG_VALGRIND-when-valgrind-is-mis.patch --]
[-- Type: text/x-diff, Size: 1718 bytes --]
From 784fdea59920d69998b59ab326c11a8a2a93ef88 Mon Sep 17 00:00:00 2001
From: Simon Josefsson <simon@josefsson.org>
Date: Fri, 14 May 2021 15:03:25 +0200
Subject: [PATCH] valgrind-tests: Fix LOG_VALGRIND when valgrind is missing.
* m4/valgrind-tests.m4: Clear all variables when missing.
---
ChangeLog | 5 +++++
m4/valgrind-tests.m4 | 11 +++++++----
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index daeb44ab4..8ab1a4b2a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2021-05-14 Simon Josefsson <simon@josefsson.org>
+
+ valgrind-tests: Fix LOG_VALGRIND when valgrind is missing.
+ * m4/valgrind-tests.m4: Clear all variables when missing.
+
2021-05-14 Simon Josefsson <simon@josefsson.org>
valgrind-tests: Better option handling.
diff --git a/m4/valgrind-tests.m4 b/m4/valgrind-tests.m4
index 9fc9d5b37..6453430e9 100644
--- a/m4/valgrind-tests.m4
+++ b/m4/valgrind-tests.m4
@@ -1,4 +1,4 @@
-# valgrind-tests.m4 serial 7
+# valgrind-tests.m4 serial 8
dnl Copyright (C) 2008-2021 Free Software Foundation, Inc.
dnl This file is free software; the Free Software Foundation
dnl gives unlimited permission to copy and/or distribute it,
@@ -79,9 +79,12 @@ AC_DEFUN_ONCE([gl_VALGRIND_TESTS],
],
[gl_cv_prog_valgrind_works=no])
])
- if test $gl_cv_prog_valgrind_works != yes; then
- VALGRIND=
- fi
+ fi
+
+ if test $gl_cv_prog_valgrind_works != yes; then
+ VALGRIND=
+ VALGRINDFLAGS=
+ DEFAULT_VALGRINDFLAGS=
fi
AC_SUBST([LOG_VALGRIND], ["\$(VALGRIND) \$(DEFAULT_VALGRINDFLAGS) \$(VALGRINDFLAGS)"])
--
2.20.1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2021-05-14 13:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 12:27 [PATCH] valgrind-tests: Better option handling Simon Josefsson via Gnulib discussion list
2021-05-14 13:07 ` Simon Josefsson via Gnulib discussion list [this message]
2021-05-14 13:47 ` Bruno Haible
2021-05-14 17:38 ` Simon Josefsson via Gnulib discussion list
2021-05-14 20:01 ` Bruno Haible
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgwxwjjv.fsf@latte.josefsson.org \
--to=bug-gnulib@gnu.org \
--cc=simon@josefsson.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).