From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id BB4381F5AE for ; Fri, 14 May 2021 13:08:41 +0000 (UTC) Received: from localhost ([::1]:55256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhXYW-0003eh-JV for normalperson@yhbt.net; Fri, 14 May 2021 09:08:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhXXF-0002GF-W9 for bug-gnulib@gnu.org; Fri, 14 May 2021 09:07:22 -0400 Received: from uggla.sjd.se ([2001:9b1:8633::107]:34840) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhXXD-0001LS-4O for bug-gnulib@gnu.org; Fri, 14 May 2021 09:07:21 -0400 DKIM-Signature: v=1; a=ed25519-sha256; q=dns/txt; c=relaxed/relaxed; d=josefsson.org; s=ed2101; h=Content-Type:MIME-Version:Message-ID:In-Reply-To :Date:References:Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding :Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=HC2L+qP/cLEK4ykmcpCMjd1t0tidV5/igI7zeAuGa/0=; t=1620997638; x=1622207238; b=/N1L3q5VWC2B6LOGJ7sD3OOp62qgz62qsMfF2rFP4VjXkWcnYiATjxuM0rqq/d9MK+3v4osH6i 8z2fZ0NWLcAg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=josefsson.org; s=rsa2101; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:To:From:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=HC2L+qP/cLEK4ykmcpCMjd1t0tidV5/igI7zeAuGa/0=; t=1620997638; x=1622207238; b=yIStfWunHIo8dVepn41Enzx7YOklUrDLjNXp9MZcYn39MRlOCiD33aOn9RIkBm+p9vH84iakgH c5QpG6nHO5qu/t657mRSHam9i6OoE0OBpLai41xLWjFBlv28HXU+YqFD5WRbZUqi3/Ndm2+6nQuo+ e9GeGDNLTEw0N/m7sasssSbBlXIH1DTK94yWgv+aSc1Tq0SdvnSpOL3u5mb3ZXdvHDMlifxAJhkXQ wPCnwRKcqFIuu2xmjI5motSjIJaiRbVbFmuvV3eg/3QKGAtPkyZ5mtecH33m1/TKWhxSZzDtSM1+F t9EgnEEEAXpPKZoTNtrWnbqy9ofCZE6hSzywmsuVUaCS2NXUDuOnXiafzr1Un6TGroRilLTUxRWtS ymuq6zI2J6EwxvDf2Of3yzKFmYnR+GGnbZsBJ9wBZsDf/iWPp82WGG5+Ij65uXRV55dHOoznMp ; Received: from [2001:9b1:41ac:ff00:d573:7565:e01a:ce5b] (port=33172 helo=latte) by uggla.sjd.se with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lhXXA-0005pQ-KH for bug-gnulib@gnu.org; Fri, 14 May 2021 13:07:16 +0000 To: Simon Josefsson via Gnulib discussion list Subject: Re: [PATCH] valgrind-tests: Better option handling. References: <87lf8hxzxx.fsf@latte.josefsson.org> OpenPGP: id=B1D2BD1375BECB784CF4F8C4D73CF638C53C06BE; url=https://josefsson.org/key-20190320.txt X-Hashcash: 1:22:210514:bug-gnulib@gnu.org::QDBC96sa/2eIZxtO:2Rop Date: Fri, 14 May 2021 15:07:16 +0200 In-Reply-To: <87lf8hxzxx.fsf@latte.josefsson.org> (Simon Josefsson via Gnulib discussion list's message of "Fri, 14 May 2021 14:27:54 +0200") Message-ID: <87zgwxwjjv.fsf@latte.josefsson.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Received-SPF: pass client-ip=2001:9b1:8633::107; envelope-from=simon@josefsson.org; helo=uggla.sjd.se X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Reply-to: Simon Josefsson From: Simon Josefsson via Gnulib discussion list --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Further testing quickly found a small bug, pushed. /Simon --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-valgrind-tests-Fix-LOG_VALGRIND-when-valgrind-is-mis.patch Content-Transfer-Encoding: quoted-printable From=20784fdea59920d69998b59ab326c11a8a2a93ef88 Mon Sep 17 00:00:00 2001 From: Simon Josefsson Date: Fri, 14 May 2021 15:03:25 +0200 Subject: [PATCH] valgrind-tests: Fix LOG_VALGRIND when valgrind is missing. * m4/valgrind-tests.m4: Clear all variables when missing. =2D-- ChangeLog | 5 +++++ m4/valgrind-tests.m4 | 11 +++++++---- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index daeb44ab4..8ab1a4b2a 100644 =2D-- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2021-05-14 Simon Josefsson + + valgrind-tests: Fix LOG_VALGRIND when valgrind is missing. + * m4/valgrind-tests.m4: Clear all variables when missing. + 2021-05-14 Simon Josefsson =20 valgrind-tests: Better option handling. diff --git a/m4/valgrind-tests.m4 b/m4/valgrind-tests.m4 index 9fc9d5b37..6453430e9 100644 =2D-- a/m4/valgrind-tests.m4 +++ b/m4/valgrind-tests.m4 @@ -1,4 +1,4 @@ =2D# valgrind-tests.m4 serial 7 +# valgrind-tests.m4 serial 8 dnl Copyright (C) 2008-2021 Free Software Foundation, Inc. dnl This file is free software; the Free Software Foundation dnl gives unlimited permission to copy and/or distribute it, @@ -79,9 +79,12 @@ AC_DEFUN_ONCE([gl_VALGRIND_TESTS], ], [gl_cv_prog_valgrind_works=3Dno]) ]) =2D if test $gl_cv_prog_valgrind_works !=3D yes; then =2D VALGRIND=3D =2D fi + fi + + if test $gl_cv_prog_valgrind_works !=3D yes; then + VALGRIND=3D + VALGRINDFLAGS=3D + DEFAULT_VALGRINDFLAGS=3D fi =20 AC_SUBST([LOG_VALGRIND], ["\$(VALGRIND) \$(DEFAULT_VALGRINDFLAGS) \$(VA= LGRINDFLAGS)"]) =2D-=20 2.20.1 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQSjzJyHC50xCrrUzy9RcisI/kdFogUCYJ52BAAKCRBRcisI/kdF omRqAP4wm1cugqc1/a4POGqRzHZZoEXfqr+kuiCr798xW1zq0AD/ee3VkDam8qws rE/dmnXs45hP/9icj/vXGQZmqx86Jwc= =dWSg -----END PGP SIGNATURE----- --==-=-=--