From: Florian Weimer <fweimer@redhat.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: bug-gnulib@gnu.org
Subject: Re: [PATCH 1/2] copy-file-range: new module
Date: Wed, 05 Jun 2019 15:54:17 +0200 [thread overview]
Message-ID: <87o93cuohi.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <20190605060917.18349-1-eggert@cs.ucla.edu> (Paul Eggert's message of "Tue, 4 Jun 2019 23:09:16 -0700")
* Paul Eggert:
> +/* Emulation of copy_file_range.
> + Copyright 2017-2019 Free Software Foundation, Inc.
> +
> + This program is free software: you can redistribute it and/or modify
> + it under the terms of the GNU General Public License as published by
> + the Free Software Foundation; either version 3 of the License, or
> + (at your option) any later version.
> +
> + This program is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + GNU General Public License for more details.
> +
> + You should have received a copy of the GNU General Public License
> + along with this program. If not, see <https://www.gnu.org/licenses/>. */
> +
> +/* This file is adapted from glibc io/copy_file_range-compat.c, with a
> + small number of changes to port to non-glibc platforms. */
This is not a valid implementation of copy_file_range anymore. Please
see the discussion here:
<https://sourceware.org/ml/libc-alpha/2019-06/msg00039.html>
If you ship this in gnulib, you should at least call this function by a
different name.
Thanks,
Florian
next prev parent reply other threads:[~2019-06-05 13:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 6:09 [PATCH 1/2] copy-file-range: new module Paul Eggert
2019-06-05 6:09 ` [PATCH 2/2] copy-file: prefer copy_file_range Paul Eggert
2019-06-05 13:54 ` Florian Weimer [this message]
2019-06-06 0:45 ` [PATCH 1/2] copy-file-range: new module Bruno Haible
2019-06-07 8:04 ` Paul Eggert
2019-06-28 18:56 ` Pádraig Brady
2019-06-28 19:30 ` Bruno Haible
2019-06-28 20:18 ` Florian Weimer
2019-06-28 22:46 ` Bruno Haible
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o93cuohi.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=bug-gnulib@gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).