From: Bruno Haible <bruno@clisp.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: bug-gnulib@gnu.org, Paul Eggert <eggert@cs.ucla.edu>
Subject: Re: [PATCH 1/2] copy-file-range: new module
Date: Sat, 29 Jun 2019 00:46:51 +0200 [thread overview]
Message-ID: <18377733.cjb9PtB3hs@omega> (raw)
In-Reply-To: <87tvc9jwfq.fsf@oldenburg2.str.redhat.com>
Florian Weimer wrote:
> > In the NEWS entry, Florian writes:
> >
> > Applications which use the
> > copy_file_range function will have to be run on kernels which implement
> > the copy_file_range system call.
> >
> > I find this misleading. Coreutils will want to continue to use
> > copy_file_range whenever the libc provides this function, and at the
> > same time be able to run on all Linux kernel versions.
>
> What's misleading about it? If you want copy_file_range functionality,
> you will need an implementation of it, and since glibc no longer
> contains one after this change, you need one from the kernel.
Like Paul said: Any reliable use of copy_file_range will need to be
followed by fallback code that does the copy through user-space.
> You can still call the function, of course, but it's use is really
> limited because it sets errno ENOSYS and returns -1.
Yes. This information is missing from the NEWS entry that you added.
Bruno
prev parent reply other threads:[~2019-06-28 22:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 6:09 [PATCH 1/2] copy-file-range: new module Paul Eggert
2019-06-05 6:09 ` [PATCH 2/2] copy-file: prefer copy_file_range Paul Eggert
2019-06-05 13:54 ` [PATCH 1/2] copy-file-range: new module Florian Weimer
2019-06-06 0:45 ` Bruno Haible
2019-06-07 8:04 ` Paul Eggert
2019-06-28 18:56 ` Pádraig Brady
2019-06-28 19:30 ` Bruno Haible
2019-06-28 20:18 ` Florian Weimer
2019-06-28 22:46 ` Bruno Haible [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18377733.cjb9PtB3hs@omega \
--to=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=fweimer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).