From: Daiki Ueno <ueno@gnu.org>
To: Bruno Haible <bruno@clisp.org>
Cc: bug-gnulib@gnu.org
Subject: Re: [PATCH] read-file: add variants that clear internal memory
Date: Wed, 27 May 2020 14:18:07 +0200 [thread overview]
Message-ID: <87h7w1bmgw.fsf-ueno@gnu.org> (raw)
In-Reply-To: <3561901.SBJZaZJKAa@omega> (Bruno Haible's message of "Wed, 27 May 2020 13:12:51 +0200")
Bruno Haible <bruno@clisp.org> writes:
> The first one is nearly perfect. Only the NEWS entry should go into section
> "User visible incompatible changes", not into section "Important general notes".
>
> The second one:
> - In fread_file, around line 100, you use a realloc workaround that appears
> to be not as reliable as the malloc+free based workaround around line 135.
> - In read_file, please don't use tabs for indentation. We've switched to
> spaces-only indentation long ago.
>
> Once this is fixed, please push.
Both has been fixed and pushed. Thank you for the review!
Regards,
--
Daiki Ueno
next prev parent reply other threads:[~2020-05-27 12:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 8:35 [PATCH] read-file: add variants that clear internal memory Daiki Ueno
2020-05-26 10:54 ` Bruno Haible
2020-05-26 16:32 ` Daiki Ueno
2020-05-26 18:33 ` Bruno Haible
2020-05-27 6:43 ` Daiki Ueno
2020-05-27 11:12 ` Bruno Haible
2020-05-27 12:18 ` Daiki Ueno [this message]
2020-05-28 20:09 ` Bruno Haible
2020-05-29 3:59 ` Daiki Ueno
2020-05-29 9:15 ` Bruno Haible
2020-05-29 15:23 ` Daiki Ueno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7w1bmgw.fsf-ueno@gnu.org \
--to=ueno@gnu.org \
--cc=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).