Re: [PATCH] read-file: add variants that clear internal memory

From: Bruno Haible <bruno@clisp.org>
To: Daiki Ueno <ueno@gnu.org>
Cc: bug-gnulib@gnu.org
Subject: Re: [PATCH] read-file: add variants that clear internal memory
Date: Tue, 26 May 2020 20:33:34 +0200	[thread overview]
Message-ID: <1883606.oFhN3a00iB@omega> (raw)
In-Reply-To: <87pnaqejxa.fsf-ueno@gnu.org>

Hi Daiki,

> > If you agree, I'd like to see two commits:
> >   1. the introduction of the flags and RF_BINARY,
> >   2. the RF_SENSITIVE flag.
> >
> > Do you want me to code the first commit, or do you want to do it?
> 
> Sure, that would make things much simpler.  I'm attaching a patch along
> these lines.

It would be useful to first concentrate on the first part, the refactoring
that introduces flags and RF_BINARY. This would provide a patch that is easier
to review and does not have the following problems:
  - internal_fread_file still exists, although fread_file is a no-op wrapper
    around it.
  - In tests/test-read-file.c, please terminate the main() function with a
    return statement. We assume C99 only in modules that explicitly list 'c99'
    as a dependency. If it's trivial to avoid this dependency, let's do it.
  - The NEWS file needs an entry.

Bruno