bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: "Pádraig Brady" <P@draigBrady.com>
To: Bruno Haible <bruno@clisp.org>, bug-gnulib@gnu.org
Subject: Re: new module 'strtold'
Date: Tue, 29 Jan 2019 21:42:56 -0800	[thread overview]
Message-ID: <76e35280-8cd3-7ecd-b5f0-ee3bf35d7013@draigBrady.com> (raw)
In-Reply-To: <15810183.GCsTEvYtY3@omega>

On 29/01/19 19:05, Bruno Haible wrote:
> Hi,
> 
> coreutils has recently started to use strtold() [1]. This causes compilation
> errors on Android 4.3:
> 
>   CC       lib/cl-strtod.o
>   CC       lib/cl-strtold.o
> In file included from ../lib/cl-strtold.c:2:
> ../lib/cl-strtod.c: In function 'cl_strtold':
> ../lib/cl-strtod.c:62: warning: implicit declaration of function 'strtold'

Oh wow, thanks for doing all that.
We previously guarded uses of strtold in coreutils with:
https://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v8.5-8-g8b5087d
which did:

  #if HAVE_C99_STRTOLD /* provided by c-strtold module.  */
  # define STRTOD strtold
  #else
  # define STRTOD strtod
  #endif
  long double a = STRTOD (sa, &ea);

We should have guarded the new code similarly.
With this new module though we've more consistent functionality
across all platforms.

thanks!
Pádraig


  reply	other threads:[~2019-01-30  5:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-30  3:05 new module 'strtold' Bruno Haible
2019-01-30  5:42 ` Pádraig Brady [this message]
2019-02-01  3:34   ` Bruno Haible
2019-02-01 22:47     ` Paul Eggert
2019-02-02  1:44       ` Bruno Haible
2019-02-01  2:16 ` strtod, strtold: various fixes Bruno Haible

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76e35280-8cd3-7ecd-b5f0-ee3bf35d7013@draigBrady.com \
    --to=p@draigbrady.com \
    --cc=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).