From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 23CD91F453 for ; Wed, 30 Jan 2019 05:43:08 +0000 (UTC) Received: from localhost ([127.0.0.1]:60808 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goieQ-0004Rz-Mg for normalperson@yhbt.net; Wed, 30 Jan 2019 00:43:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54451) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goieK-0004QS-S7 for bug-gnulib@gnu.org; Wed, 30 Jan 2019 00:43:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1goieK-0005W0-6B for bug-gnulib@gnu.org; Wed, 30 Jan 2019 00:43:00 -0500 Received: from mail.magicbluesmoke.com ([82.195.144.49]:43668) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1goieK-0005VL-1L for bug-gnulib@gnu.org; Wed, 30 Jan 2019 00:43:00 -0500 Received: from localhost.localdomain (unknown [76.21.115.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.magicbluesmoke.com (Postfix) with ESMTPSA id 1F919A560; Wed, 30 Jan 2019 05:42:57 +0000 (GMT) Subject: Re: new module 'strtold' To: Bruno Haible , bug-gnulib@gnu.org References: <15810183.GCsTEvYtY3@omega> From: =?UTF-8?Q?P=c3=a1draig_Brady?= Message-ID: <76e35280-8cd3-7ecd-b5f0-ee3bf35d7013@draigBrady.com> Date: Tue, 29 Jan 2019 21:42:56 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <15810183.GCsTEvYtY3@omega> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 82.195.144.49 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" On 29/01/19 19:05, Bruno Haible wrote: > Hi, >=20 > coreutils has recently started to use strtold() [1]. This causes compil= ation > errors on Android 4.3: >=20 > CC lib/cl-strtod.o > CC lib/cl-strtold.o > In file included from ../lib/cl-strtold.c:2: > ../lib/cl-strtod.c: In function 'cl_strtold': > ../lib/cl-strtod.c:62: warning: implicit declaration of function 'strto= ld' Oh wow, thanks for doing all that. We previously guarded uses of strtold in coreutils with: https://git.sv.gnu.org/gitweb/?p=3Dcoreutils.git;a=3Dcommitdiff;h=3Dv8.5-= 8-g8b5087d which did: #if HAVE_C99_STRTOLD /* provided by c-strtold module. */ # define STRTOD strtold #else # define STRTOD strtod #endif long double a =3D STRTOD (sa, &ea); We should have guarded the new code similarly. With this new module though we've more consistent functionality across all platforms. thanks! P=C3=A1draig