bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Akim Demaille <akim@lrde.epita.fr>
To: Bruno Haible <bruno@clisp.org>
Cc: Paul Eggert <eggert@cs.ucla.edu>, bug-gnulib@gnu.org
Subject: Re: backup-rename: update dependencies
Date: Sun, 13 Jan 2019 19:45:32 +0100	[thread overview]
Message-ID: <7354A7B2-0301-4FC7-9A3F-4BCEEF3CB9FB@lrde.epita.fr> (raw)
In-Reply-To: <1748941.T314m9taBN@omega>

Hi Bruno!

> Le 13 janv. 2019 à 13:31, Bruno Haible <bruno@clisp.org> a écrit :
> 
> Hi Akim,
> 
>> I tried to use the backup-rename module, and it failed to compile for lack of "opendirat.h".  So I think we need this patch.
>> 
>> Cheers!
>> 
>> 
>> commit ffd5d5bb4b282d4e7a1f83d5a60ade30bac5a6f1
>> Author: Akim Demaille <akim.demaille@gmail.com>
>> Date:   Sun Jan 13 11:16:20 2019 +0100
>> 
>>    backup-rename: update dependencies
>> 
>>    * modules/backup-rename (Depends-on): It now depends on opendirat
>>    instead of opendir.
> 
> Good finding. The issue originated in the commit from 2018-10-24
> 1b01fe40918401a965651499b0ba37ff53be86a9 .
> 
> When you look at this commit, you'll see two more modifications of
> modules/backupfile that need to be replicated in modules/backup-rename.

I think that it's more than this.

It seems quite difficult to track these dependencies.  Can nothing be automated there?

commit ec77a711543fcaf17676ad4b63a2ce850f124a86
Author: Akim Demaille <akim.demaille@gmail.com>
Date:   Sun Jan 13 11:16:20 2019 +0100

    backup: update dependencies
    
    * modules/backup-rename (Depends-on): It now depends on opendirat
    instead of opendir.  It also uses stdbool, and xalloc-oversized.
    But no longer dirfd.
    * modules/backupfile (Depends-on): Add xalloc-oversized.

diff --git a/ChangeLog b/ChangeLog
index 81f83349e..d49779499 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2019-01-13  Akim Demaille  <akim@lrde.epita.fr>
+
+	backup: update dependencies
+	* modules/backup-rename (Depends-on): It now depends on opendirat
+	instead of opendir.  It also uses stdbool, and xalloc-oversized.
+	But no longer dirfd.
+	* modules/backupfile (Depends-on): Add xalloc-oversized.
+
 2019-01-10  Bruno Haible  <bruno@clisp.org>
 
 	verify: Enable _GL_HAVE_STATIC_ASSERT for recent G++ versions.
diff --git a/modules/backup-rename b/modules/backup-rename
index 7e551af52..3cb37ddcf 100644
--- a/modules/backup-rename
+++ b/modules/backup-rename
@@ -13,14 +13,15 @@ argmatch
 closedir
 d-ino
 dirent-safer
-dirfd
 dirname-lgpl
 fcntl
 memcmp
-opendir
-renameatu
+opendirat
 readdir
+renameatu
 stdbool
+stdint
+xalloc-oversized
 
 configure.ac:
 gl_BACKUPFILE
diff --git a/modules/backupfile b/modules/backupfile
index 5dcf6c708..429faa6bf 100644
--- a/modules/backupfile
+++ b/modules/backupfile
@@ -17,11 +17,12 @@ dirname-lgpl
 fcntl
 memcmp
 opendirat
-renameatu
 readdir
+renameatu
 stdbool
 stdint
 xalloc
+xalloc-oversized
 
 configure.ac:
 gl_BACKUPFILE



  reply	other threads:[~2019-01-13 18:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-13 10:30 backup-rename: update dependencies Akim Demaille
2019-01-13 12:31 ` Bruno Haible
2019-01-13 18:45   ` Akim Demaille [this message]
2019-01-13 20:40     ` Paul Eggert
2019-01-13 23:42     ` Bruno Haible
2019-01-14 18:43       ` Akim Demaille

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7354A7B2-0301-4FC7-9A3F-4BCEEF3CB9FB@lrde.epita.fr \
    --to=akim@lrde.epita.fr \
    --cc=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).