From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id EC2C8211B4 for ; Sun, 13 Jan 2019 18:45:45 +0000 (UTC) Received: from localhost ([127.0.0.1]:33872 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giklT-0008FW-LZ for normalperson@yhbt.net; Sun, 13 Jan 2019 13:45:43 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giklP-0008FM-Jj for bug-gnulib@gnu.org; Sun, 13 Jan 2019 13:45:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1giklO-00027y-7N for bug-gnulib@gnu.org; Sun, 13 Jan 2019 13:45:39 -0500 Received: from smtp.lrde.epita.fr ([163.5.55.2]:55480) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giklN-00022L-WA for bug-gnulib@gnu.org; Sun, 13 Jan 2019 13:45:38 -0500 Received: from io.home (unknown [83.202.133.85]) by smtp.lrde.epita.fr (Postfix) with ESMTPSA id A92F3413C0; Sun, 13 Jan 2019 19:45:32 +0100 (CET) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: backup-rename: update dependencies From: Akim Demaille In-Reply-To: <1748941.T314m9taBN@omega> Date: Sun, 13 Jan 2019 19:45:32 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <7354A7B2-0301-4FC7-9A3F-4BCEEF3CB9FB@lrde.epita.fr> References: <26AB7DE6-7FD6-4201-8B20-6378DCD9AD5C@lrde.epita.fr> <1748941.T314m9taBN@omega> To: Bruno Haible X-Mailer: Apple Mail (2.3445.102.3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 163.5.55.2 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Eggert , bug-gnulib@gnu.org Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Hi Bruno! > Le 13 janv. 2019 =C3=A0 13:31, Bruno Haible a =C3=A9cr= it : >=20 > Hi Akim, >=20 >> I tried to use the backup-rename module, and it failed to compile for = lack of "opendirat.h". So I think we need this patch. >>=20 >> Cheers! >>=20 >>=20 >> commit ffd5d5bb4b282d4e7a1f83d5a60ade30bac5a6f1 >> Author: Akim Demaille >> Date: Sun Jan 13 11:16:20 2019 +0100 >>=20 >> backup-rename: update dependencies >>=20 >> * modules/backup-rename (Depends-on): It now depends on opendirat >> instead of opendir. >=20 > Good finding. The issue originated in the commit from 2018-10-24 > 1b01fe40918401a965651499b0ba37ff53be86a9 . >=20 > When you look at this commit, you'll see two more modifications of > modules/backupfile that need to be replicated in = modules/backup-rename. I think that it's more than this. It seems quite difficult to track these dependencies. Can nothing be = automated there? commit ec77a711543fcaf17676ad4b63a2ce850f124a86 Author: Akim Demaille Date: Sun Jan 13 11:16:20 2019 +0100 backup: update dependencies =20 * modules/backup-rename (Depends-on): It now depends on opendirat instead of opendir. It also uses stdbool, and xalloc-oversized. But no longer dirfd. * modules/backupfile (Depends-on): Add xalloc-oversized. diff --git a/ChangeLog b/ChangeLog index 81f83349e..d49779499 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2019-01-13 Akim Demaille + + backup: update dependencies + * modules/backup-rename (Depends-on): It now depends on = opendirat + instead of opendir. It also uses stdbool, and xalloc-oversized. + But no longer dirfd. + * modules/backupfile (Depends-on): Add xalloc-oversized. + 2019-01-10 Bruno Haible =20 verify: Enable _GL_HAVE_STATIC_ASSERT for recent G++ versions. diff --git a/modules/backup-rename b/modules/backup-rename index 7e551af52..3cb37ddcf 100644 --- a/modules/backup-rename +++ b/modules/backup-rename @@ -13,14 +13,15 @@ argmatch closedir d-ino dirent-safer -dirfd dirname-lgpl fcntl memcmp -opendir -renameatu +opendirat readdir +renameatu stdbool +stdint +xalloc-oversized =20 configure.ac: gl_BACKUPFILE diff --git a/modules/backupfile b/modules/backupfile index 5dcf6c708..429faa6bf 100644 --- a/modules/backupfile +++ b/modules/backupfile @@ -17,11 +17,12 @@ dirname-lgpl fcntl memcmp opendirat -renameatu readdir +renameatu stdbool stdint xalloc +xalloc-oversized =20 configure.ac: gl_BACKUPFILE