From: Paul Eggert <eggert@cs.ucla.edu>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org, bug-gnulib@gnu.org
Subject: Re: [PATCH v2 4/6] stdlib: Sync canonicalize with gnulib [BZ #10635] [BZ #26592] [BZ #26341] [BZ #24970]
Date: Mon, 28 Dec 2020 13:07:54 -0800 [thread overview]
Message-ID: <6eaea6a5-4064-ba5d-8d69-26529d3ae4c3@cs.ucla.edu> (raw)
In-Reply-To: <20201228135944.1018303-4-adhemerval.zanella@linaro.org>
On 12/28/20 5:59 AM, Adhemerval Zanella wrote:
> It sync with gnulib version bbaba6ce5 with the following difference
> require fix a glibc build:
>
> --- stdlib/canonicalize.c
> +++ lib/canonicalize-lgpl.c
> @@ -52,7 +52,6 @@
> # endif
> # define GCC_LINT 1
> # define _GL_ATTRIBUTE_PURE __attribute__ ((__pure__))
> -# define FUNC_REALPATH_WORKS 1
I hope a better fix for that problem is this change:
-#if !FUNC_REALPATH_WORKS || defined _LIBC
+#if defined _LIBC || !FUNC_REALPATH_WORKS
which I just installed into Gnulib
<https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=18bc1ab1feca304d2a357407af8e29b3354496f2>.
This sort of technique works in the "# if defined _LIBC ||
HAVE_FACCESSAT" line later on.
next prev parent reply other threads:[~2020-12-28 21:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 13:59 [PATCH v2 1/6] Import idx.h from gnulib Adhemerval Zanella
2020-12-28 13:59 ` [PATCH v2 2/6] Import filename.h " Adhemerval Zanella
2020-12-28 13:59 ` [PATCH v2 3/6] malloc: Add scratch_buffer_dupfree Adhemerval Zanella
2020-12-28 13:59 ` [PATCH v2 4/6] stdlib: Sync canonicalize with gnulib [BZ #10635] [BZ #26592] [BZ #26341] [BZ #24970] Adhemerval Zanella
2020-12-28 21:07 ` Paul Eggert [this message]
2020-12-28 13:59 ` [PATCH v2 5/6] stdlibc: Simplify realpath via scratch_buffer_dupfree Adhemerval Zanella
2020-12-28 13:59 ` [PATCH v2 6/6] stdlib: Assume FACCESSAT_NEVER_EOVERFLOWS on realpath Adhemerval Zanella
2020-12-28 21:14 ` Paul Eggert
2020-12-28 21:50 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6eaea6a5-4064-ba5d-8d69-26529d3ae4c3@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=adhemerval.zanella@linaro.org \
--cc=bug-gnulib@gnu.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).