From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id CD0231F4B4 for ; Mon, 28 Dec 2020 21:08:02 +0000 (UTC) Received: from localhost ([::1]:53614 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktzkI-0006LG-0K for normalperson@yhbt.net; Mon, 28 Dec 2020 16:08:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33450) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktzkE-0006JB-B3 for bug-gnulib@gnu.org; Mon, 28 Dec 2020 16:07:58 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:39062) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktzkC-0005M3-N1 for bug-gnulib@gnu.org; Mon, 28 Dec 2020 16:07:58 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 91FAF160087; Mon, 28 Dec 2020 13:07:55 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 57gXrg5GvmnB; Mon, 28 Dec 2020 13:07:54 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A4EFF1600CD; Mon, 28 Dec 2020 13:07:54 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 8oQiDMjsZt26; Mon, 28 Dec 2020 13:07:54 -0800 (PST) Received: from [192.168.1.9] (cpe-23-243-218-95.socal.res.rr.com [23.243.218.95]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 7C56E160087; Mon, 28 Dec 2020 13:07:54 -0800 (PST) Subject: Re: [PATCH v2 4/6] stdlib: Sync canonicalize with gnulib [BZ #10635] [BZ #26592] [BZ #26341] [BZ #24970] To: Adhemerval Zanella References: <20201228135944.1018303-1-adhemerval.zanella@linaro.org> <20201228135944.1018303-4-adhemerval.zanella@linaro.org> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <6eaea6a5-4064-ba5d-8d69-26529d3ae4c3@cs.ucla.edu> Date: Mon, 28 Dec 2020 13:07:54 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201228135944.1018303-4-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=131.179.128.68; envelope-from=eggert@cs.ucla.edu; helo=zimbra.cs.ucla.edu X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-2.698, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: libc-alpha@sourceware.org, bug-gnulib@gnu.org Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" On 12/28/20 5:59 AM, Adhemerval Zanella wrote: > It sync with gnulib version bbaba6ce5 with the following difference > require fix a glibc build: > > --- stdlib/canonicalize.c > +++ lib/canonicalize-lgpl.c > @@ -52,7 +52,6 @@ > # endif > # define GCC_LINT 1 > # define _GL_ATTRIBUTE_PURE __attribute__ ((__pure__)) > -# define FUNC_REALPATH_WORKS 1 I hope a better fix for that problem is this change: -#if !FUNC_REALPATH_WORKS || defined _LIBC +#if defined _LIBC || !FUNC_REALPATH_WORKS which I just installed into Gnulib . This sort of technique works in the "# if defined _LIBC || HAVE_FACCESSAT" line later on.