From: Bruno Haible <bruno@clisp.org>
To: Daiki Ueno <ueno@gnu.org>
Cc: "Tim Rühsen" <tim.ruehsen@gmx.de>, bug-gnulib@gnu.org
Subject: Re: portability of fopen and 'e' (O_CLOEXEC) flag
Date: Thu, 28 May 2020 13:54:24 +0200 [thread overview]
Message-ID: <3990195.UIfvkoD8i4@omega> (raw)
In-Reply-To: <87wo4wnzoj.fsf-ueno@gnu.org>
Hi Daiki,
Thank you for noticing this, and the rapid fix.
> Sorry, attached an old patch; this would be simpler (and also supports
> other platforms that need O_BINARY).
> + ASSERT (fwrite (DATA, 1, sizeof(DATA)-1, f) == sizeof(DATA)-1);
...
> + ASSERT (fread (buf, 1, sizeof(buf), f) == sizeof(DATA)-1);
GNU coding style wants a space between 'sizeof' and the opening parenthesis.
Other than that, your patch is perfect.
Thanks again!
Bruno
next prev parent reply other threads:[~2020-05-28 11:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 14:49 portability of fopen and 'e' (O_CLOEXEC) flag Tim Rühsen
2020-05-11 16:37 ` Bruno Haible
2020-05-11 17:41 ` Eric Blake
2020-05-12 8:28 ` Tim Rühsen
2020-05-24 19:22 ` Bruno Haible
2020-05-26 6:01 ` Daiki Ueno
2020-05-26 8:18 ` Bruno Haible
2020-05-26 16:09 ` Bruno Haible
2020-05-27 18:39 ` Bruno Haible
2020-05-28 10:00 ` Daiki Ueno
2020-05-28 10:04 ` Daiki Ueno
2020-05-28 11:54 ` Bruno Haible [this message]
2020-05-29 3:04 ` Daiki Ueno
2020-05-29 6:25 ` Bruno Haible
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3990195.UIfvkoD8i4@omega \
--to=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
--cc=tim.ruehsen@gmx.de \
--cc=ueno@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).