From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 3CC461F55B for ; Thu, 28 May 2020 11:54:36 +0000 (UTC) Received: from localhost ([::1]:60140 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeH7L-0003rt-2t for normalperson@yhbt.net; Thu, 28 May 2020 07:54:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56134) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeH7I-0003re-8V for bug-gnulib@gnu.org; Thu, 28 May 2020 07:54:32 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.221]:28719) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeH7G-0002YC-Kb; Thu, 28 May 2020 07:54:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1590666866; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=JB/yLCWhIE5dQPZq4FCfQVTwvu+f+Z5O7PwHJoXuM50=; b=YpwI8FgpCNrc3MMJ0GWXl4LfkX2LTOH9KFhmYIu1NO8VB0chv246vh6dUsog7hdcJF tEvDAaZq92Y3uIGEh5pQ6JhoI1IMpVqin0JUT2MjaAoh5yhZBdhZLujjAmqqQGuSuhQ/ SeA9YLRh/HI8/dp5raqxGPr7wC30mQXtN1ziuu+8nTRGRtQQKb6TUIsbhxYQwSRJNsC8 eb+bc3BH/sfNj84kABdO5mS5cK57IYaBgHHjC9N5bbt3omXNiNauShx7npIFP3ggCtKr NJA/C+vcWWzzoGTN1EtYH67+vFI3TSw5uTAlCtk3KgpsGcYgne1Zvxy/oYhOTtWgEHle 7cqQ== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOH6fzxfs=" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 46.9.0 DYNA|AUTH) with ESMTPSA id j03713w4SBsP2Jm (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Thu, 28 May 2020 13:54:25 +0200 (CEST) From: Bruno Haible To: Daiki Ueno Subject: Re: portability of fopen and 'e' (O_CLOEXEC) flag Date: Thu, 28 May 2020 13:54:24 +0200 Message-ID: <3990195.UIfvkoD8i4@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-177-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <87wo4wnzoj.fsf-ueno@gnu.org> References: <7d7cfa6e-af75-82d0-e076-bf411b87a3ab@gmx.de> <877dwwpefb.fsf-ueno@gnu.org> <87wo4wnzoj.fsf-ueno@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: none client-ip=81.169.146.221; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/28 07:54:26 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tim =?ISO-8859-1?Q?R=FChsen?= , bug-gnulib@gnu.org Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Hi Daiki, Thank you for noticing this, and the rapid fix. > Sorry, attached an old patch; this would be simpler (and also supports > other platforms that need O_BINARY). > + ASSERT (fwrite (DATA, 1, sizeof(DATA)-1, f) == sizeof(DATA)-1); ... > + ASSERT (fread (buf, 1, sizeof(buf), f) == sizeof(DATA)-1); GNU coding style wants a space between 'sizeof' and the opening parenthesis. Other than that, your patch is perfect. Thanks again! Bruno