From: Bruno Haible <bruno@clisp.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: bug-gnulib@gnu.org
Subject: Re: [PROPOSED 4/4] explicit_bzero: implement via memset_explicit
Date: Tue, 29 Nov 2022 09:09:03 +0100 [thread overview]
Message-ID: <2749034.XrmoMso0CX@nimes> (raw)
In-Reply-To: <915880f6-f261-25ea-d533-7d708758441c@cs.ucla.edu>
Paul Eggert wrote:
> Thanks for the detailed review. I installed the patches with corrections
> that I hope addressed all your comments.
Thanks Paul. Very nice!
> > I don't understand the purpose of this line:
> > memset (checkbuf, i, SECRET_SIZE);
> > Wouldn't it be better to have
> > memcpy (stbuf, SECRET, SECRET_SIZE);
> > instead?
>
> I added the latter call but kept the former
Perfect. Indeed, I misread the proposed code. Sorry.
Bruno
next prev parent reply other threads:[~2022-11-29 8:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 4:55 [PROPOSED 0/4] memset_explicit patches Paul Eggert
2022-11-28 4:55 ` [PROPOSED 1/4] memset_explicit: new module Paul Eggert
2022-11-28 16:17 ` Bruno Haible
2022-11-28 4:55 ` [PROPOSED 2/4] read-file: use memset_explicit Paul Eggert
2022-11-28 4:55 ` [PROPOSED 3/4] explicit_bzero: memset_explicit is standard Paul Eggert
2022-11-28 4:55 ` [PROPOSED 4/4] explicit_bzero: implement via memset_explicit Paul Eggert
2022-11-28 16:17 ` Bruno Haible
2022-11-29 6:06 ` Paul Eggert
2022-11-29 8:09 ` Bruno Haible [this message]
2022-11-28 10:15 ` [PROPOSED 0/4] memset_explicit patches Simon Josefsson via Gnulib discussion list
2022-11-28 16:04 ` Bruno Haible
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2749034.XrmoMso0CX@nimes \
--to=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).