From: Bruno Haible <bruno@clisp.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: bug-gnulib@gnu.org
Subject: Re: [PATCH] fchmodat, lchmod: port to buggy Linux filesystems
Date: Sun, 23 Feb 2020 11:58:45 +0100 [thread overview]
Message-ID: <2690728.gVUGnRkd8D@omega> (raw)
In-Reply-To: <9cfa2499-f466-065f-4f32-7f68523bde91@cs.ucla.edu>
Hi Paul,
> found that I had trouble reading the code
That's probably because I prefer the "one code for each platform" approach when
suitable - because when debugging problems I don't like to rely to
$CC ... -E file.c > file.i
to tell me which code is actually enabled -, whereas you seem to prefer a
"global minimum of lines" approach. It's understandable that I find your code
hard to understand and vice versa.
I'm not saying that one is better than the other; just trying to explain why
we find each other's code odd here.
> Instead of making it more complicated still I snipped away everything I
> couldn't figure out the need for, and installed the attached.
>
> Perhaps I went too far and some of the complications need to be brought back,
> but I hope not....
The fchmodat part looks right.
On the other hand, the lchmod part looks wrong: You stripped away the
test $REPLACE_LCHMOD = 1
case. However, the file doc/glibc-functions/lchmod.texi still says
Portability problems fixed by Gnulib:
@itemize
...
@item
This function always fails with @code{errno} set to @code{ENOSYS},
even when the file is not a symbolic link:
GNU/Linux with glibc 2.31.
Overriding the system's lchmod function requires the case REPLACE_LCHMOD=1.
Bruno
next prev parent reply other threads:[~2020-02-23 10:58 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 18:42 [PATCH] fchmodat, lchmod: port to buggy Linux filesystems Paul Eggert
2020-02-14 3:29 ` Bruno Haible
2020-02-16 17:24 ` Bruno Haible
2020-02-16 18:31 ` Paul Eggert
2020-02-16 18:58 ` Bruno Haible
2020-02-14 3:46 ` Bruno Haible
2020-02-14 21:02 ` Paul Eggert
2020-02-16 21:38 ` Bruno Haible
2020-02-16 22:28 ` Bruno Haible
2020-02-22 23:46 ` Bruno Haible
2020-02-23 8:15 ` Paul Eggert
2020-02-23 10:58 ` Bruno Haible [this message]
2020-02-23 23:56 ` Paul Eggert
2020-02-24 2:27 ` overriding glibc stub functions Bruno Haible
2020-02-24 7:44 ` Paul Eggert
2020-02-23 1:35 ` [PATCH] fchmodat, lchmod: port to buggy Linux filesystems Bruno Haible
2020-02-23 7:22 ` Paul Eggert
2020-03-09 17:30 ` Pádraig Brady
2020-03-09 18:51 ` Paul Eggert
2020-03-09 23:45 ` Pádraig Brady
2020-03-10 11:52 ` Florian Weimer
2020-03-10 15:09 ` Kamil Dudka
2020-03-10 19:27 ` Pádraig Brady
2020-03-10 19:30 ` Florian Weimer
2020-03-11 8:03 ` Paul Eggert
2020-03-11 8:45 ` Florian Weimer
2020-03-11 16:04 ` Paul Eggert
2020-03-11 8:25 ` Paul Eggert
2020-03-11 8:40 ` Florian Weimer
2020-03-11 9:04 ` Kamil Dudka
2020-03-11 16:36 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2690728.gVUGnRkd8D@omega \
--to=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).