From: Paul Eggert <eggert@cs.ucla.edu>
To: Kamil Dudka <kdudka@redhat.com>, Florian Weimer <fw@deneb.enyo.de>
Cc: bug-gnulib@gnu.org
Subject: Re: [PATCH] fchmodat, lchmod: port to buggy Linux filesystems
Date: Wed, 11 Mar 2020 09:36:06 -0700 [thread overview]
Message-ID: <0e56f052-402e-54d0-a4fd-9b8e8d53925b@cs.ucla.edu> (raw)
In-Reply-To: <1847517.PYKUYFuaPT@nbkamil>
On 3/11/20 2:04 AM, Kamil Dudka wrote:
> Would not it make sense to fix this in mknod by turning the EOPNOTSUPP
> failure into a warning only?
No, because that would be a regression. mknod used to work in this case, and now
it doesn't.
Formerly, Gnulib-using programs like mknod worked around the problem that glibc
lchmod always failed, by silently substituting chmod for lchmod in all cases and
not bothering to call lchmod. Now that glibc lchmod merely *sometimes* fails,
Gnulib-using problems need a fancier workaround.
Most likely this workaround will consist of changing the 'configure'-time test
for lchmod. Currently, the 'configure'-time test checks whether lchmod fails on
a non-symlink. The simplest fix is to change the 'configure'-time test so that
it always fails if the Linux kernel is being used. (Presumably we'll do the same
for Cygwin and for Android.)
prev parent reply other threads:[~2020-03-11 16:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 18:42 [PATCH] fchmodat, lchmod: port to buggy Linux filesystems Paul Eggert
2020-02-14 3:29 ` Bruno Haible
2020-02-16 17:24 ` Bruno Haible
2020-02-16 18:31 ` Paul Eggert
2020-02-16 18:58 ` Bruno Haible
2020-02-14 3:46 ` Bruno Haible
2020-02-14 21:02 ` Paul Eggert
2020-02-16 21:38 ` Bruno Haible
2020-02-16 22:28 ` Bruno Haible
2020-02-22 23:46 ` Bruno Haible
2020-02-23 8:15 ` Paul Eggert
2020-02-23 10:58 ` Bruno Haible
2020-02-23 23:56 ` Paul Eggert
2020-02-24 2:27 ` overriding glibc stub functions Bruno Haible
2020-02-24 7:44 ` Paul Eggert
2020-02-23 1:35 ` [PATCH] fchmodat, lchmod: port to buggy Linux filesystems Bruno Haible
2020-02-23 7:22 ` Paul Eggert
2020-03-09 17:30 ` Pádraig Brady
2020-03-09 18:51 ` Paul Eggert
2020-03-09 23:45 ` Pádraig Brady
2020-03-10 11:52 ` Florian Weimer
2020-03-10 15:09 ` Kamil Dudka
2020-03-10 19:27 ` Pádraig Brady
2020-03-10 19:30 ` Florian Weimer
2020-03-11 8:03 ` Paul Eggert
2020-03-11 8:45 ` Florian Weimer
2020-03-11 16:04 ` Paul Eggert
2020-03-11 8:25 ` Paul Eggert
2020-03-11 8:40 ` Florian Weimer
2020-03-11 9:04 ` Kamil Dudka
2020-03-11 16:36 ` Paul Eggert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e56f052-402e-54d0-a4fd-9b8e8d53925b@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=bug-gnulib@gnu.org \
--cc=fw@deneb.enyo.de \
--cc=kdudka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).