* array-list: Pacify warnings about unused arguments (-Wunused-parameter)
@ 2019-01-23 21:37 Akim Demaille
2019-01-23 22:24 ` Eric Blake
0 siblings, 1 reply; 3+ messages in thread
From: Akim Demaille @ 2019-01-23 21:37 UTC (permalink / raw)
To: Gnulib bugs
In Bison.
commit decda5a491a8e8900bea0f4346d8dfca191d4b90
Author: Akim Demaille <akim.demaille@gmail.com>
Date: Wed Jan 23 22:36:54 2019 +0100
array-list: Pacify warnings about unused arguments (-Wunused-parameter)
* lib/gl_array_list.c (gl_array_iterator_free): "Use" the argument.
diff --git a/ChangeLog b/ChangeLog
index 2fccadb5e..b9e15a10a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2019-01-23 Akim Demaille <akim@lrde.epita.fr>
+
+ array-list: Pacify warnings about unused arguments (-Wunused-parameter).
+ * lib/gl_array_list.c (gl_array_iterator_free): "Use" the argument.
+
2019-01-23 Akim Demaille <akim@lrde.epita.fr>
relocatable: avoid compiler warnings (-Wshadow).
diff --git a/lib/gl_array_list.c b/lib/gl_array_list.c
index 812c50211..0c7325e91 100644
--- a/lib/gl_array_list.c
+++ b/lib/gl_array_list.c
@@ -514,6 +514,7 @@ gl_array_iterator_next (gl_list_iterator_t *iterator,
static void
gl_array_iterator_free (gl_list_iterator_t *iterator)
{
+ (void) iterator;
}
/* ---------------------- Sorted gl_list_t Data Type ---------------------- */
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: array-list: Pacify warnings about unused arguments (-Wunused-parameter)
2019-01-23 21:37 array-list: Pacify warnings about unused arguments (-Wunused-parameter) Akim Demaille
@ 2019-01-23 22:24 ` Eric Blake
2019-01-24 6:39 ` Akim Demaille
0 siblings, 1 reply; 3+ messages in thread
From: Eric Blake @ 2019-01-23 22:24 UTC (permalink / raw)
To: Akim Demaille, Gnulib bugs
[-- Attachment #1.1: Type: text/plain, Size: 879 bytes --]
On 1/23/19 3:37 PM, Akim Demaille wrote:
> In Bison.
>
> commit decda5a491a8e8900bea0f4346d8dfca191d4b90
> Author: Akim Demaille <akim.demaille@gmail.com>
> Date: Wed Jan 23 22:36:54 2019 +0100
>
> array-list: Pacify warnings about unused arguments (-Wunused-parameter)
>
> * lib/gl_array_list.c (gl_array_iterator_free): "Use" the argument.
> +++ b/lib/gl_array_list.c
> @@ -514,6 +514,7 @@ gl_array_iterator_next (gl_list_iterator_t *iterator,
> static void
> gl_array_iterator_free (gl_list_iterator_t *iterator)
> {
> + (void) iterator;
Why not this:
-gl_array_iterator_free (gl_list_iterator_t *iterator)
+gl_array_iterator_free (gl_list_iterator_t *iterator _GL_UNUSED)
like we do elsewhere?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-24 6:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-23 21:37 array-list: Pacify warnings about unused arguments (-Wunused-parameter) Akim Demaille
2019-01-23 22:24 ` Eric Blake
2019-01-24 6:39 ` Akim Demaille
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).