bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Bruno Haible <bruno@clisp.org>
To: Ondrej Valousek <ondrej.valousek.xm@renesas.com>,
	bug-gnulib@gnu.org, bug-gnulib@gnu.org,
	Paul Eggert <eggert@cs.ucla.edu>
Cc: kdudka@redhat.com
Subject: Re: [PATCH] Use xattr (Linux) in copy-acl.c
Date: Tue, 03 Jan 2023 21:53:37 +0100	[thread overview]
Message-ID: <19520338.sIn9rWBj0N@nimes> (raw)
In-Reply-To: <f3b7375a-ef32-d5c2-c1d3-779ecb591716@cs.ucla.edu>

Paul Eggert wrote:
> > +static int
> > +copy_attr_permissions (const char *name, struct error_context *ctx)
> > +{
> > +	int action = attr_copy_action (name, ctx);
> > +	return action == ATTR_ACTION_PERMISSIONS;
> > +}
> 
> 
> This returns bool not int, so it should be declared to return bool.

Nope. This function is used as a callback for attr_copy_file and
attr_copy_fd [1] and therefore needs 'int' as return type.

Bruno

[1] https://git.savannah.nongnu.org/gitweb/?p=attr.git;a=blob;f=include/libattr.h;hb=HEAD#l27





  reply	other threads:[~2023-01-03 20:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-03 14:08 [PATCH] Use xattr (Linux) in copy-acl.c Ondrej Valousek
2023-01-03 16:44 ` Bruno Haible
2023-01-03 20:40 ` Paul Eggert
2023-01-03 20:53   ` Bruno Haible [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-01-04 10:03 Ondrej Valousek
2023-01-04 11:27 ` Bruno Haible

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19520338.sIn9rWBj0N@nimes \
    --to=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=kdudka@redhat.com \
    --cc=ondrej.valousek.xm@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).