From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 10CD61F47C for ; Tue, 3 Jan 2023 20:54:02 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=clisp.org header.i=@clisp.org header.a=rsa-sha256 header.s=strato-dkim-0002 header.b=YFspC4Sw; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pCoII-0003tY-7t; Tue, 03 Jan 2023 15:53:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCoIG-0003tN-Ir for bug-gnulib@gnu.org; Tue, 03 Jan 2023 15:53:57 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.54]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCoID-00081m-Tw; Tue, 03 Jan 2023 15:53:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1672779218; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=Xu6yGTQvAMlau24IaCmhuW3QAcpVVGRzbNDWL857Ty0=; b=YFspC4SwAlRyyH8PxT2wZ4+WQfzjPVMG7YdF3nxBN/LvwIadrYOmt3qbAYkJNBDRcR DqXUA2lNnKV4Aoimh+KAJIFEMlAqRk/B63Pck5BQaCHLRFoJ6Y9figJsmJxNmaeSvWQt yDA28YDGse1bhNbRNglQbFxAkjs43Od/gmr9+RntxvINi4VsILtLiNBd/dGmCki3ErpR OvrZNdDjZciOLPeTeCbzM+rtUYmKNlJsh2rcaPBWjDTmN8BFFp1cbwo5tF2EMLsaRN6v 4Tov7m//FEb7HoKxPUHBY+DidHSHJzTskYo5LE6s52NWEPP+FWxUI3YGGdHUHuDWi0WC wL0A== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH0WWb0LN8XZoH94zq68+3cfpOX2vdClfEwFaPfEGVf28qrkcyD5w==" X-RZG-CLASS-ID: mo00 Received: from nimes.localnet by smtp.strato.de (RZmta 48.2.1 AUTH) with ESMTPSA id t05890z03Krb1po (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Tue, 3 Jan 2023 21:53:37 +0100 (CET) From: Bruno Haible To: Ondrej Valousek , bug-gnulib@gnu.org, bug-gnulib@gnu.org, Paul Eggert Cc: kdudka@redhat.com Subject: Re: [PATCH] Use xattr (Linux) in copy-acl.c Date: Tue, 03 Jan 2023 21:53:37 +0100 Message-ID: <19520338.sIn9rWBj0N@nimes> In-Reply-To: References: <20230103140816.1121699-1-ondrej.valousek.xm@renesas.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: none client-ip=85.215.255.54; envelope-from=bruno@clisp.org; helo=mo4-p01-ob.smtp.rzone.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Paul Eggert wrote: > > +static int > > +copy_attr_permissions (const char *name, struct error_context *ctx) > > +{ > > + int action = attr_copy_action (name, ctx); > > + return action == ATTR_ACTION_PERMISSIONS; > > +} > > > This returns bool not int, so it should be declared to return bool. Nope. This function is used as a callback for attr_copy_file and attr_copy_fd [1] and therefore needs 'int' as return type. Bruno [1] https://git.savannah.nongnu.org/gitweb/?p=attr.git;a=blob;f=include/libattr.h;hb=HEAD#l27