From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Subject: Re: [PATCH] areadlink-with-size: guess a lower bound with 0 size
Date: Sat, 06 Jul 2019 00:59:13 +0200 [thread overview]
Message-ID: <1771959.urycGr0Odh@omega> (raw)
In-Reply-To: <d63dd86e-9c51-0930-1cac-e2e8be5f2e1f@draigBrady.com>
Pádraig Brady wrote:
> + areadlink-with-size: guess a lower bound with 0 size
The patch looks good to me. Except that now, with the shrink-before-return in
place, the term "lower bound" is no longer appropriate. A better term is
probably "Initial memory allocation".
Bruno
next prev parent reply other threads:[~2019-07-05 22:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7AC7AA2A-EDEA-4A80-9A5A-02FAA2D823EF@whamcloud.com>
2019-07-04 10:44 ` [PATCH] stat: don't explicitly request file size for filenames Pádraig Brady
2019-07-04 11:24 ` [PATCH] areadlink-with-size: guess a lower bound with 0 size Pádraig Brady
2019-07-05 15:43 ` Jim Meyering
2019-07-05 22:59 ` Bruno Haible [this message]
2019-07-04 19:39 ` [PATCH] stat: don't explicitly request file size for filenames Andreas Dilger
2019-07-04 23:19 ` Andreas Dilger
2019-07-05 1:30 ` Bruno Haible
2019-07-05 2:36 ` Bruno Haible
2019-07-05 22:56 ` Bruno Haible
2019-07-05 23:53 ` Paul Eggert
2019-07-06 19:10 ` [PATCH] areadlink-with-size: guess a buffer size with 0 size Pádraig Brady
2019-07-07 2:28 ` Paul Eggert
2019-07-19 3:24 ` Bruno Haible
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1771959.urycGr0Odh@omega \
--to=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).