* Fix several "warning: no previous prototype for function"
@ 2020-09-05 21:53 Bruno Haible
0 siblings, 0 replies; only message in thread
From: Bruno Haible @ 2020-09-05 21:53 UTC (permalink / raw)
To: bug-gnulib
[-- Attachment #1: Type: text/plain, Size: 2526 bytes --]
Building libunistring with clang, I see these warnings:
lib/unicase/locale-languages.h(99,1): warning: no previous prototype for function 'uc_locale_languages_lookup' [-Wmissing-prototypes]
lib/uninorm/composition-table.h(57,1): warning: no previous prototype for function 'gl_uninorm_compose_lookup' [-Wmissing-prototypes]
tests/select.c(264,1): warning: no previous prototype for function 'rpl_select' [-Wmissing-prototypes]
unictype/bidi_byname.gperf(83,1): warning: no previous prototype for function 'uc_bidi_class_lookup' [-Wmissing-prototypes]
unictype/categ_byname.gperf(74,1): warning: no previous prototype for function 'uc_general_category_lookup' [-Wmissing-prototypes]
unictype/combiningclass_byname.gperf(65,1): warning: no previous prototype for function 'uc_combining_class_lookup' [-Wmissing-prototypes]
unictype/joininggroup_byname.gperf(19,1): warning: no previous prototype for function 'uc_joining_group_lookup' [-Wmissing-prototypes]
unictype/joiningtype_byname.gperf(24,1): warning: no previous prototype for function 'uc_joining_type_lookup' [-Wmissing-prototypes]
unictype/pr_byname.gperf(100,1): warning: no previous prototype for function 'uc_property_lookup' [-Wmissing-prototypes]
unictype/scripts_byname.gperf(148,1): warning: no previous prototype for function 'uc_script_lookup' [-Wmissing-prototypes]
These two patches fix these warnings.
2020-09-05 Bruno Haible <bruno@clisp.org>
Fix several "warning: no previous prototype for function".
* modules/unicase/locale-language (Makefile.am): Add a 'static' keyword
in front of the declaration of the lookup function in
unicase/locale-languages.h.
* modules/unictype/bidiclass-byname (Makefile.am): Likewise in
unictype/bidi_byname.h.
* modules/unictype/category-byname (Makefile.am): Likewise in
unictype/categ_byname.h.
* modules/unictype/combining-class-byname (Makefile.am): Likewise in
unictype/combiningclass_byname.h.
* modules/unictype/joininggroup-byname (Makefile.am): Likewise in
unictype/joininggroup_byname.h.
* modules/unictype/joiningtype-byname (Makefile.am): Likewise in
unictype/joiningtype_byname.h.
* modules/unictype/property-byname (Makefile.am): Likewise in
unictype/pr_byname.h.
* modules/unictype/scripts (Makefile.am): Likewise in
unictype/scripts_byname.h.
* modules/uninorm/composition (Makefile.am): Likewise in
uninorm/composition-table.h.
2020-09-05 Bruno Haible <bruno@clisp.org>
select: Fix "warning: no previous prototype for function".
* lib/select.c: Include <sys/select.h>.
[-- Attachment #2: 0001-select-Fix-warning-no-previous-prototype-for-functio.patch --]
[-- Type: text/x-patch, Size: 1474 bytes --]
From 373419b6c173c53b33d653ef6ea2d84bb3c0d268 Mon Sep 17 00:00:00 2001
From: Bruno Haible <bruno@clisp.org>
Date: Sat, 5 Sep 2020 23:45:47 +0200
Subject: [PATCH 1/2] select: Fix "warning: no previous prototype for
function".
* lib/select.c: Include <sys/select.h>.
---
ChangeLog | 5 +++++
lib/select.c | 8 +++++---
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 2edba65..3698ba0 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
2020-09-05 Bruno Haible <bruno@clisp.org>
+ select: Fix "warning: no previous prototype for function".
+ * lib/select.c: Include <sys/select.h>.
+
+2020-09-05 Bruno Haible <bruno@clisp.org>
+
Use module 'c99' when needed for variadic macros with '...' syntax.
* modules/crypto/sm3 (Depends-on): Add c99.
diff --git a/lib/select.c b/lib/select.c
index b2234ea..1122fde 100644
--- a/lib/select.c
+++ b/lib/select.c
@@ -19,12 +19,15 @@
with this program; if not, see <https://www.gnu.org/licenses/>. */
#include <config.h>
-#include <alloca.h>
-#include <assert.h>
+
+/* Specification. */
+#include <sys/select.h>
#if defined _WIN32 && ! defined __CYGWIN__
/* Native Windows. */
+#include <alloca.h>
+#include <assert.h>
#include <sys/types.h>
#include <errno.h>
#include <limits.h>
@@ -553,7 +556,6 @@ restart:
#else /* ! Native Windows. */
-#include <sys/select.h>
#include <stddef.h> /* NULL */
#include <errno.h>
#include <unistd.h>
--
2.7.4
[-- Attachment #3: 0002-Fix-several-warning-no-previous-prototype-for-functi.patch --]
[-- Type: text/x-patch, Size: 13376 bytes --]
From 1cc98c12499b2ef7b6f67591bafbfb230f8f8330 Mon Sep 17 00:00:00 2001
From: Bruno Haible <bruno@clisp.org>
Date: Sat, 5 Sep 2020 23:50:09 +0200
Subject: [PATCH 2/2] Fix several "warning: no previous prototype for
function".
* modules/unicase/locale-language (Makefile.am): Add a 'static' keyword
in front of the declaration of the lookup function in
unicase/locale-languages.h.
* modules/unictype/bidiclass-byname (Makefile.am): Likewise in
unictype/bidi_byname.h.
* modules/unictype/category-byname (Makefile.am): Likewise in
unictype/categ_byname.h.
* modules/unictype/combining-class-byname (Makefile.am): Likewise in
unictype/combiningclass_byname.h.
* modules/unictype/joininggroup-byname (Makefile.am): Likewise in
unictype/joininggroup_byname.h.
* modules/unictype/joiningtype-byname (Makefile.am): Likewise in
unictype/joiningtype_byname.h.
* modules/unictype/property-byname (Makefile.am): Likewise in
unictype/pr_byname.h.
* modules/unictype/scripts (Makefile.am): Likewise in
unictype/scripts_byname.h.
* modules/uninorm/composition (Makefile.am): Likewise in
uninorm/composition-table.h.
---
ChangeLog | 23 +++++++++++++++++++++++
modules/unicase/locale-language | 7 ++++---
modules/unictype/bidiclass-byname | 7 ++++---
modules/unictype/category-byname | 7 ++++---
modules/unictype/combining-class-byname | 7 ++++---
modules/unictype/joininggroup-byname | 7 ++++---
modules/unictype/joiningtype-byname | 7 ++++---
modules/unictype/property-byname | 7 ++++---
modules/unictype/scripts | 7 ++++---
modules/uninorm/composition | 7 ++++---
10 files changed, 59 insertions(+), 27 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 3698ba0..454bd76 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,28 @@
2020-09-05 Bruno Haible <bruno@clisp.org>
+ Fix several "warning: no previous prototype for function".
+ * modules/unicase/locale-language (Makefile.am): Add a 'static' keyword
+ in front of the declaration of the lookup function in
+ unicase/locale-languages.h.
+ * modules/unictype/bidiclass-byname (Makefile.am): Likewise in
+ unictype/bidi_byname.h.
+ * modules/unictype/category-byname (Makefile.am): Likewise in
+ unictype/categ_byname.h.
+ * modules/unictype/combining-class-byname (Makefile.am): Likewise in
+ unictype/combiningclass_byname.h.
+ * modules/unictype/joininggroup-byname (Makefile.am): Likewise in
+ unictype/joininggroup_byname.h.
+ * modules/unictype/joiningtype-byname (Makefile.am): Likewise in
+ unictype/joiningtype_byname.h.
+ * modules/unictype/property-byname (Makefile.am): Likewise in
+ unictype/pr_byname.h.
+ * modules/unictype/scripts (Makefile.am): Likewise in
+ unictype/scripts_byname.h.
+ * modules/uninorm/composition (Makefile.am): Likewise in
+ uninorm/composition-table.h.
+
+2020-09-05 Bruno Haible <bruno@clisp.org>
+
select: Fix "warning: no previous prototype for function".
* lib/select.c: Include <sys/select.h>.
diff --git a/modules/unicase/locale-language b/modules/unicase/locale-language
index 0ca9c29..1e6c26a 100644
--- a/modules/unicase/locale-language
+++ b/modules/unicase/locale-language
@@ -19,10 +19,11 @@ lib_SOURCES += unicase/locale-language.c
endif
$(srcdir)/unicase/locale-languages.h: $(srcdir)/unicase/locale-languages.gperf
- $(V_GPERF)$(GPERF) -m 10 $(srcdir)/unicase/locale-languages.gperf > $(srcdir)/unicase/locale-languages.h-t && \
- mv $(srcdir)/unicase/locale-languages.h-t $(srcdir)/unicase/locale-languages.h
+ $(V_GPERF)$(GPERF) -m 10 $(srcdir)/unicase/locale-languages.gperf > $(srcdir)/unicase/locale-languages.h-t1 \
+ && sed -e 's/^const/static const/' < $(srcdir)/unicase/locale-languages.h-t1 > $(srcdir)/unicase/locale-languages.h-t2 \
+ && mv $(srcdir)/unicase/locale-languages.h-t2 $(srcdir)/unicase/locale-languages.h
BUILT_SOURCES += unicase/locale-languages.h
-MOSTLYCLEANFILES += unicase/locale-languages.h-t
+MOSTLYCLEANFILES += unicase/locale-languages.h-t1 unicase/locale-languages.h-t2
MAINTAINERCLEANFILES += unicase/locale-languages.h
EXTRA_DIST += unicase/locale-languages.h
diff --git a/modules/unictype/bidiclass-byname b/modules/unictype/bidiclass-byname
index e41b4f0..ceade91 100644
--- a/modules/unictype/bidiclass-byname
+++ b/modules/unictype/bidiclass-byname
@@ -18,10 +18,11 @@ lib_SOURCES += unictype/bidi_byname.c
endif
$(srcdir)/unictype/bidi_byname.h: $(srcdir)/unictype/bidi_byname.gperf
- $(V_GPERF)$(GPERF) -m 10 $(srcdir)/unictype/bidi_byname.gperf > $(srcdir)/unictype/bidi_byname.h-t && \
- mv $(srcdir)/unictype/bidi_byname.h-t $(srcdir)/unictype/bidi_byname.h
+ $(V_GPERF)$(GPERF) -m 10 $(srcdir)/unictype/bidi_byname.gperf > $(srcdir)/unictype/bidi_byname.h-t1 \
+ && sed -e 's/^const/static const/' < $(srcdir)/unictype/bidi_byname.h-t1 > $(srcdir)/unictype/bidi_byname.h-t2 \
+ && mv $(srcdir)/unictype/bidi_byname.h-t2 $(srcdir)/unictype/bidi_byname.h
BUILT_SOURCES += unictype/bidi_byname.h
-MOSTLYCLEANFILES += unictype/bidi_byname.h-t
+MOSTLYCLEANFILES += unictype/bidi_byname.h-t1 unictype/bidi_byname.h-t2
MAINTAINERCLEANFILES += unictype/bidi_byname.h
EXTRA_DIST += unictype/bidi_byname.h
diff --git a/modules/unictype/category-byname b/modules/unictype/category-byname
index a011733..df08bcd 100644
--- a/modules/unictype/category-byname
+++ b/modules/unictype/category-byname
@@ -57,10 +57,11 @@ lib_SOURCES += unictype/categ_byname.c
endif
$(srcdir)/unictype/categ_byname.h: $(srcdir)/unictype/categ_byname.gperf
- $(V_GPERF)$(GPERF) -m 10 $(srcdir)/unictype/categ_byname.gperf > $(srcdir)/unictype/categ_byname.h-t && \
- mv $(srcdir)/unictype/categ_byname.h-t $(srcdir)/unictype/categ_byname.h
+ $(V_GPERF)$(GPERF) -m 10 $(srcdir)/unictype/categ_byname.gperf > $(srcdir)/unictype/categ_byname.h-t1 \
+ && sed -e 's/^const/static const/' < $(srcdir)/unictype/categ_byname.h-t1 > $(srcdir)/unictype/categ_byname.h-t2 \
+ && mv $(srcdir)/unictype/categ_byname.h-t2 $(srcdir)/unictype/categ_byname.h
BUILT_SOURCES += unictype/categ_byname.h
-MOSTLYCLEANFILES += unictype/categ_byname.h-t
+MOSTLYCLEANFILES += unictype/categ_byname.h-t1 unictype/categ_byname.h-t2
MAINTAINERCLEANFILES += unictype/categ_byname.h
EXTRA_DIST += unictype/categ_byname.h
diff --git a/modules/unictype/combining-class-byname b/modules/unictype/combining-class-byname
index e4a70a3..f4d0194 100644
--- a/modules/unictype/combining-class-byname
+++ b/modules/unictype/combining-class-byname
@@ -18,10 +18,11 @@ lib_SOURCES += unictype/combiningclass_byname.c
endif
$(srcdir)/unictype/combiningclass_byname.h: $(srcdir)/unictype/combiningclass_byname.gperf
- $(V_GPERF)$(GPERF) -m 10 $(srcdir)/unictype/combiningclass_byname.gperf > $(srcdir)/unictype/combiningclass_byname.h-t && \
- mv $(srcdir)/unictype/combiningclass_byname.h-t $(srcdir)/unictype/combiningclass_byname.h
+ $(V_GPERF)$(GPERF) -m 10 $(srcdir)/unictype/combiningclass_byname.gperf > $(srcdir)/unictype/combiningclass_byname.h-t1 \
+ && sed -e 's/^const/static const/' < $(srcdir)/unictype/combiningclass_byname.h-t1 > $(srcdir)/unictype/combiningclass_byname.h-t2 \
+ && mv $(srcdir)/unictype/combiningclass_byname.h-t2 $(srcdir)/unictype/combiningclass_byname.h
BUILT_SOURCES += unictype/combiningclass_byname.h
-MOSTLYCLEANFILES += unictype/combiningclass_byname.h-t
+MOSTLYCLEANFILES += unictype/combiningclass_byname.h-t1 unictype/combiningclass_byname.h-t2
MAINTAINERCLEANFILES += unictype/combiningclass_byname.h
EXTRA_DIST += unictype/combiningclass_byname.h
diff --git a/modules/unictype/joininggroup-byname b/modules/unictype/joininggroup-byname
index cb5765f..a86df45 100644
--- a/modules/unictype/joininggroup-byname
+++ b/modules/unictype/joininggroup-byname
@@ -18,10 +18,11 @@ lib_SOURCES += unictype/joininggroup_byname.c
endif
$(srcdir)/unictype/joininggroup_byname.h: $(srcdir)/unictype/joininggroup_byname.gperf
- $(V_GPERF)$(GPERF) -m 10 $(srcdir)/unictype/joininggroup_byname.gperf > $(srcdir)/unictype/joininggroup_byname.h-t && \
- mv $(srcdir)/unictype/joininggroup_byname.h-t $(srcdir)/unictype/joininggroup_byname.h
+ $(V_GPERF)$(GPERF) -m 10 $(srcdir)/unictype/joininggroup_byname.gperf > $(srcdir)/unictype/joininggroup_byname.h-t1 \
+ && sed -e 's/^const/static const/' < $(srcdir)/unictype/joininggroup_byname.h-t1 > $(srcdir)/unictype/joininggroup_byname.h-t2 \
+ && mv $(srcdir)/unictype/joininggroup_byname.h-t2 $(srcdir)/unictype/joininggroup_byname.h
BUILT_SOURCES += unictype/joininggroup_byname.h
-MOSTLYCLEANFILES += unictype/joininggroup_byname.h-t
+MOSTLYCLEANFILES += unictype/joininggroup_byname.h-t1 unictype/joininggroup_byname.h-t2
MAINTAINERCLEANFILES += unictype/joininggroup_byname.h
EXTRA_DIST += unictype/joininggroup_byname.h
diff --git a/modules/unictype/joiningtype-byname b/modules/unictype/joiningtype-byname
index 8c8c669..e89794f 100644
--- a/modules/unictype/joiningtype-byname
+++ b/modules/unictype/joiningtype-byname
@@ -18,10 +18,11 @@ lib_SOURCES += unictype/joiningtype_byname.c
endif
$(srcdir)/unictype/joiningtype_byname.h: $(srcdir)/unictype/joiningtype_byname.gperf
- $(V_GPERF)$(GPERF) -m 10 $(srcdir)/unictype/joiningtype_byname.gperf > $(srcdir)/unictype/joiningtype_byname.h-t && \
- mv $(srcdir)/unictype/joiningtype_byname.h-t $(srcdir)/unictype/joiningtype_byname.h
+ $(V_GPERF)$(GPERF) -m 10 $(srcdir)/unictype/joiningtype_byname.gperf > $(srcdir)/unictype/joiningtype_byname.h-t1 \
+ && sed -e 's/^const/static const/' < $(srcdir)/unictype/joiningtype_byname.h-t1 > $(srcdir)/unictype/joiningtype_byname.h-t2 \
+ && mv $(srcdir)/unictype/joiningtype_byname.h-t2 $(srcdir)/unictype/joiningtype_byname.h
BUILT_SOURCES += unictype/joiningtype_byname.h
-MOSTLYCLEANFILES += unictype/joiningtype_byname.h-t
+MOSTLYCLEANFILES += unictype/joiningtype_byname.h-t1 unictype/joiningtype_byname.h-t2
MAINTAINERCLEANFILES += unictype/joiningtype_byname.h
EXTRA_DIST += unictype/joiningtype_byname.h
diff --git a/modules/unictype/property-byname b/modules/unictype/property-byname
index 0a10709..9ffe6ef 100644
--- a/modules/unictype/property-byname
+++ b/modules/unictype/property-byname
@@ -104,10 +104,11 @@ lib_SOURCES += unictype/pr_byname.c
endif
$(srcdir)/unictype/pr_byname.h: $(srcdir)/unictype/pr_byname.gperf
- $(V_GPERF)$(GPERF) -m 10 $(srcdir)/unictype/pr_byname.gperf > $(srcdir)/unictype/pr_byname.h-t && \
- mv $(srcdir)/unictype/pr_byname.h-t $(srcdir)/unictype/pr_byname.h
+ $(V_GPERF)$(GPERF) -m 10 $(srcdir)/unictype/pr_byname.gperf > $(srcdir)/unictype/pr_byname.h-t1 \
+ && sed -e 's/^const/static const/' < $(srcdir)/unictype/pr_byname.h-t1 > $(srcdir)/unictype/pr_byname.h-t2 \
+ && mv $(srcdir)/unictype/pr_byname.h-t2 $(srcdir)/unictype/pr_byname.h
BUILT_SOURCES += unictype/pr_byname.h
-MOSTLYCLEANFILES += unictype/pr_byname.h-t
+MOSTLYCLEANFILES += unictype/pr_byname.h-t1 unictype/pr_byname.h-t2
MAINTAINERCLEANFILES += unictype/pr_byname.h
EXTRA_DIST += unictype/pr_byname.h
diff --git a/modules/unictype/scripts b/modules/unictype/scripts
index 8f8b057..12185e0 100644
--- a/modules/unictype/scripts
+++ b/modules/unictype/scripts
@@ -19,10 +19,11 @@ lib_SOURCES += unictype/scripts.c
endif
$(srcdir)/unictype/scripts_byname.h: $(srcdir)/unictype/scripts_byname.gperf
- $(V_GPERF)$(GPERF) -m 10 $(srcdir)/unictype/scripts_byname.gperf > $(srcdir)/unictype/scripts_byname.h-t && \
- mv $(srcdir)/unictype/scripts_byname.h-t $(srcdir)/unictype/scripts_byname.h
+ $(V_GPERF)$(GPERF) -m 10 $(srcdir)/unictype/scripts_byname.gperf > $(srcdir)/unictype/scripts_byname.h-t1 \
+ && sed -e 's/^const/static const/' < $(srcdir)/unictype/scripts_byname.h-t1 > $(srcdir)/unictype/scripts_byname.h-t2 \
+ && mv $(srcdir)/unictype/scripts_byname.h-t2 $(srcdir)/unictype/scripts_byname.h
BUILT_SOURCES += unictype/scripts_byname.h
-MOSTLYCLEANFILES += unictype/scripts_byname.h-t
+MOSTLYCLEANFILES += unictype/scripts_byname.h-t1 unictype/scripts_byname.h-t2
MAINTAINERCLEANFILES += unictype/scripts_byname.h
EXTRA_DIST += unictype/scripts_byname.h
diff --git a/modules/uninorm/composition b/modules/uninorm/composition
index 6ab319d..3299644 100644
--- a/modules/uninorm/composition
+++ b/modules/uninorm/composition
@@ -18,10 +18,11 @@ lib_SOURCES += uninorm/composition.c
endif
$(srcdir)/uninorm/composition-table.h: $(srcdir)/uninorm/composition-table.gperf
- $(V_GPERF)$(GPERF) -m 1 $(srcdir)/uninorm/composition-table.gperf > $(srcdir)/uninorm/composition-table.h-t && \
- mv $(srcdir)/uninorm/composition-table.h-t $(srcdir)/uninorm/composition-table.h
+ $(V_GPERF)$(GPERF) -m 1 $(srcdir)/uninorm/composition-table.gperf > $(srcdir)/uninorm/composition-table.h-t1 \
+ && sed -e 's/^const/static const/' < $(srcdir)/uninorm/composition-table.h-t1 > $(srcdir)/uninorm/composition-table.h-t2 \
+ && mv $(srcdir)/uninorm/composition-table.h-t2 $(srcdir)/uninorm/composition-table.h
BUILT_SOURCES += uninorm/composition-table.h
-MOSTLYCLEANFILES += uninorm/composition-table.h-t
+MOSTLYCLEANFILES += uninorm/composition-table.h-t1 uninorm/composition-table.h-t2
MAINTAINERCLEANFILES += uninorm/composition-table.h
EXTRA_DIST += uninorm/composition-table.h
--
2.7.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-09-05 21:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-05 21:53 Fix several "warning: no previous prototype for function" Bruno Haible
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).