| Date | Commit message (Collapse) |
|---|
|
We'll still be keeping "repobrowse" for the public API
for use with .psgi files, but shortening the name means
less typing and we may have command-line tools, too.
|
|
This shortens the code quite a bit at a negligible performance cost,
and the diffstat agrees.
|
|
This prevents "git show" processes from monopolizing
the system and allows us to better handle backpressure
from gigantic commits.
|
|
We'll be migrating away from it to minimize dependencies
and surprises, just like the rest of public-inbox did
several months ago.
|
|
It's unnecessary to rely so much on the req hashref
like this and having to manually drop references could
be considered code smell.
|
|
In /diff/ and /commit/ endpoints, making the word "diff"
a link to the top of the diff is not very useful and may
be confusing. Avoid wasting bandwidth and overloading
the reader with potential options.
|
|
diff generation takes an indeterminate amount of time,
so avoid blocking our -httpd process if possible and
rely on Danga::Socket. This falls back to synchronous
execution as does the rest of public-inbox WWW code.
|
|
We avoid creating an extra hashref to share more code
with the /diff/ view. Furthermore, more preparation for
making the /commit/ view use Danga::Socket
|
|
It is too noisy and still hurts readability on some
displays.
|
|
This reduces the amount of duplicated code between the
"diff" and "commit" views of repobrowse.
|
|
No point in wasting stack space for that.
|
|
We'll be moving to Danga::Socket for giant diff generation in
future commits. So this is a step towards being more
callback-driven...
|
|
We shall save clients the overhead of making extra HTTP requests
to follow partial paths. This ought to improve cache hit
effectiveness on both the server and client side by reducing
the potential different pages we may set.
|
|
It is expensive and of dubious usefulness to have tree content
auto-followed and indexed by search engines. Reduce the
links we recommend to crawlers so they don't waste resources
of users running our code or waste the time of search engine
users finding low-value content.
We will allow indexing blobs, however, as they may contain
useful information for others to refer to.
Of course, I definitely want search engines to index commit
messages; as I consider those to be the most important data
served.
|
|
Having too many potential links is damaging to cacheability
and hurts performance.
|
|
This doesn't look too horrible on displays which render italics
and even degrades gracefully in text-only displays to underline
or colors in other terminals (lynx). Do not italicize leading
whitespace, since the fallback to underlines looks too noisy.
|
|
We will use core.abbrev=12 by default if unset, as the git
default of 7 is too low for long-term usability of links.
Some of our callers used 16, which was probably excessive.
|
|
While we want to keep a consistent set of parameters across
different VCSes, we cannot expect users of non-git VCSes to
use the same parameter names which make sense for git users.
|
|
We mainly call it "repobrowse" (all lowercase), so do not imply
it is two separate words by capitalizing "Browse".
|